[DD4hep] Fix switched names of ECal volumes, first step

[cvuosalo]

The number of physical volumes produced by Run 3 DD4hep is greater than that produced by the old DD. One problem was that
some VFE ECal volumes had their names switched around in DD4hep compared to the old DD. This PR fixes that mix-up. The number of physical volumes for Run 3 in old DD is 21339. Before this PR, DD4hep produced 21391 volumes. With this PR, this number goes down to 21354. There are still more fixes required to get to an exact match, but this PR provides a first step and provides a starting point for other developers to make more fixes.

PR validation:

The numbers of "ECVFE" and "EVFE" physical volumes from debugging messages were checked before and after this PR using these two test scripts:

Geometry/EcalCommonData/test/python/dumpECDDD_cfg.py
Geometry/EcalCommonData/test/python/dumpECDD4Hep_cfg.py

Before this PR, the numbers did not match, but after this PR, there was an exact match for these volumes between old DD and DD4hep.

No backport is planned.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32702/20817

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Geometry/EcalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @fabiocos, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

type bug-fix

[cvuosalo]

@ianna FYI

[cvuosalo]

@bsunanda Please review the changes in this PR. There are still more volume mismatches. I noticed "EBCBAR" volumes don't match between old DD and DD4hep. If you have time to investigate, that would be helpful. Thanks.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a70243/12402/summary.html
COMMIT: 5bb7cda
CMSSW: CMSSW_11_3_X_2021-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32702/12402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2895 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 9385
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2707553
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cvuosalo]

The comparison differences are due to the DD4hep workflow. This PR changes DD4hep geometry, so it is expected that differences would be created. They are mostly due to different events being generated for the reference and PR simulation steps.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

urgent

[qliphy]

+1