Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECAL spike killer settings for Run 3, backport of #32701 #32719

Merged

Conversation

tlampen
Copy link
Contributor

@tlampen tlampen commented Jan 22, 2021

PR description:

This PR provides re-optimized ECAL spike killer settings for Run 3. Details of the payloads and their validation can be found in the presentation at the 18 Jan 2021 AlCaDB meeting.

The GT diffs are as follows:

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v14/112X_mcRun3_2021_realistic_v15

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v14/112X_mcRun3_2021cosmics_realistic_deco_v15

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v14/112X_mcRun3_2021_realistic_HI_v15

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v14/112X_mcRun3_2023_realistic_v15

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v14/112X_mcRun3_2024_realistic_v15

PR validation:

The payloads were validated by explicitly comparing dumps of the new payload with the old (see slide 5) and checking the performance with re-emulated trigger primitives (see slide 6).

In addition, a technical test was performed for PR #32701 (not for this PR):

runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #32701 .

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jan 22, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2021

A new Pull Request was created by @tlampen (Tapio Lampn) for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tlampen
Copy link
Contributor Author

tlampen commented Jan 22, 2021

please test

@christopheralanwest
Copy link
Contributor

backport #32701

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8f74d/12482/summary.html
COMMIT: 3b061dd
CMSSW: CMSSW_11_2_X_2021-01-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32719/12482/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529596
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor

+1

  • GT differences identical to those in the PR to master
  • No unexpected changes seen in comparison tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 25, 2021

+1

@cmsbuild cmsbuild merged commit 996a5f3 into cms-sw:CMSSW_11_2_X Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants