Add L1T fractional prescale record [11_2_X] #32772

christopheralanwest · 2021-01-29T20:58:01Z

PR description:

This PR is a backport of PR #32758 and PR #32774. It also contains a fix to the data GTs to use the tag L1TGlobalPrescalesVetosFract_Stage2v1_hlt rather than L1TGlobalPrescalesVetosFract_Stage2_v2_hlt instead, as discussed at #32741 (comment).

This PR adds a fractional prescale record L1TGlobalPrescalesVetosFract_Stage2v1_hlt for data GTs and L1TGlobalPrescalesVetosFract_passThrough_mc for MC to accommodate the new fractional L1 prescale functionality.

The additional removal of SiPixelCPEGenericErrorParmRcd from 112X_dataRun2_HLT_relval_v3 and 112X_dataRun2_HLT_relval_HI_v2 is a technical change only, removing an obsolete record.

The GT diffs are as follows:

Run 2 (L1 trigger stage 1)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_l1stage1_v1/112X_mcRun2_asymptotic_l1stage1_v2

2016 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_design_v1/112X_mcRun2_design_v2

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_preVFP_v2/112X_mcRun2_asymptotic_preVFP_v3

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_v2/112X_mcRun2_asymptotic_v3

2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2cosmics_asymptotic_deco_v2/112X_mcRun2cosmics_asymptotic_deco_v3

Run 2 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_HeavyIon_v1/112X_mcRun2_HeavyIon_v2

Run 2 proton-lead
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_pA_v1/112X_mcRun2_pA_v2

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_v7/112X_dataRun2_v8

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HEfail_v7/112X_dataRun2_HEfail_v8

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_relval_v7/112X_dataRun2_relval_v8

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_PromptLike_HI_v5/112X_dataRun2_PromptLike_HI_v6

Run 2 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_HLT_relval_v9/112X_dataRun2_HLT_relval_v3

Run 2 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_HLT_relval_HI_v5/112X_dataRun2_HLT_relval_HI_v2

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_dataRun3_Express_v4/112X_dataRun3_Express_v2

Run 3 data (prompt)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_dataRun3_Prompt_v5/112X_dataRun3_Prompt_v2

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_design_v2/112X_mc2017_design_v3

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017_realistic_v4/112X_mc2017_realistic_v5

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_deco_v4/112X_mc2017cosmics_realistic_deco_v5

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mc2017cosmics_realistic_peak_v4/112X_mc2017cosmics_realistic_peak_v5

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_design_v4/112X_upgrade2018_design_v5

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v7/112X_upgrade2018_realistic_v8

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v7/112X_upgrade2018_realistic_HI_v8

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v7/112X_upgrade2018_realistic_HEfail_v8

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v7/112X_upgrade2018cosmics_realistic_deco_v8

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v7/112X_upgrade2018cosmics_realistic_peak_v8

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v12/112X_mcRun3_2021_design_v13

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v15/112X_mcRun3_2021_realistic_v16

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v15/112X_mcRun3_2021cosmics_realistic_deco_v16

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v15/112X_mcRun3_2021_realistic_HI_v16

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v15/112X_mcRun3_2023_realistic_v16

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v15/112X_mcRun3_2024_realistic_v16

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun4_realistic_v5/112X_mcRun4_realistic_v6

PR validation:

The tag for data was prepared by ensuring that the fractional prescale payload is consistent with that used for the old, legacy, integral prescales. See the following presentation for details: https://indico.cern.ch/event/974057/#35-integration-of-l1t-new-frac

In addition, technical tests were performed:

addOnTests -j 8 and runTheMatrix.py -l limited,1325.516,7.22,136.8642,10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #32758 (with an additional bug fix) to 112X for use in the upcoming MWGR.

christopheralanwest · 2021-01-29T20:58:15Z

backport #32758

cmsbuild · 2021-01-29T20:58:23Z

A new Pull Request was created by @christopheralanwest for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Add L1T fractional prescale record #32758

christopheralanwest · 2021-01-29T20:59:34Z

test parameters

workflow = 1325.516,7.22,136.8642,10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0
pull_request = Pr112x Fractional Prescales L1T + HLT and L1T uGT displaced muons #32744

christopheralanwest · 2021-01-29T21:01:12Z

please test

cmsbuild · 2021-01-30T00:00:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dc09b/12606/summary.html
COMMIT: da0c2d8
CMSSW: CMSSW_11_2_X_2021-01-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32772/12606/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2529619
DQMHistoTests: Total failures: 113
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529484
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 151 log files, 37 edm output root files, 36 DQM output files

christopheralanwest · 2021-01-30T01:53:43Z

@rekovic @hjkwon260 Please let me know if the differences in the comparison tests are as expected. Alternatively, I could test this PR with the now-closed PR #32377 to try to eliminate the differences arising from the uGT emulation of displaced muons.

silviodonato · 2021-02-01T09:34:26Z

test parameters

workflow = 1325.516,7.22,136.8642,10424.0,7.21,11224.0,11024.2,7.4,12024.0,7.23,159.0,12834.0
pull_request = Pr112x L1T Fractional Prescales implemented with Global Trigger #32377

silviodonato · 2021-02-01T09:34:34Z

please test

silviodonato · 2021-02-01T09:37:46Z

@rekovic @hjkwon260 Please let me know if the differences in the comparison tests are as expected. Alternatively, I could test this PR with the now-closed PR #32377 to try to eliminate the differences arising from the uGT emulation of displaced muons.

The differences were related to the L1 muons, so it should be ok

cmsbuild · 2021-02-01T12:32:19Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dc09b/12617/summary.html
COMMIT: da0c2d8
CMSSW: CMSSW_11_2_X_2021-01-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32772/12617/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

1333.0DAS Error

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5dc09b/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2529619
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529587
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 151 log files, 37 edm output root files, 36 DQM output files

christopheralanwest · 2021-02-01T14:38:32Z

+1

Backport has same GT differences as PR to master (aside from two removals of obsolete tags)
No differences observed in PR comparison tests aside from known reproducibility issues
Failure in last round of tests not seen in previous round and unrelated to this PR

cmsbuild · 2021-02-01T14:38:56Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-02-01T16:09:27Z

+1
the error in dasgoclient --limit 0 --query 'file dataset=/RelValPhotonJets_Pt_10_13/CMSSW_10_6_0-106X_mcRun2_asymptotic_v3-v1/GEN-SIM site=T2_CH_CERN' | ibeos-lfn-sort -u > step1_dasquery.log 2>&1 is definitely not related to this PR

silviodonato · 2021-02-01T17:07:39Z

merge

Add L1T fractional prescale record

da0c2d8

cmsbuild added this to the CMSSW_11_2_X milestone Jan 29, 2021

cmsbuild added alca-pending backport-ok orp-pending pending-signatures tests-pending labels Jan 29, 2021

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2021

christopheralanwest changed the title ~~Add L1T fractional prescale record~~ Add L1T fractional prescale record [11_2_X] Jan 30, 2021

christopheralanwest mentioned this pull request Jan 30, 2021

Use correct fractional prescale tag in data global tags #32774

Merged

cmsbuild added tests-started and removed tests-approved labels Feb 1, 2021

cmsbuild added tests-rejected and removed tests-started labels Feb 1, 2021

cmsbuild removed alca-pending pending-signatures labels Feb 1, 2021

cmsbuild added alca-approved fully-signed labels Feb 1, 2021

Martin-Grunewald mentioned this pull request Feb 1, 2021

Pr112x Fractional Prescales L1T + HLT and L1T uGT displaced muons #32744

Merged

cmsbuild added orp-approved and removed orp-pending labels Feb 1, 2021

cmsbuild merged commit 5913eaf into cms-sw:CMSSW_11_2_X Feb 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add L1T fractional prescale record [11_2_X] #32772

Add L1T fractional prescale record [11_2_X] #32772

christopheralanwest commented Jan 29, 2021 •

edited

christopheralanwest commented Jan 29, 2021

cmsbuild commented Jan 29, 2021 •

edited

christopheralanwest commented Jan 29, 2021

christopheralanwest commented Jan 29, 2021

cmsbuild commented Jan 30, 2021

christopheralanwest commented Jan 30, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

christopheralanwest commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

Add L1T fractional prescale record [11_2_X] #32772

Add L1T fractional prescale record [11_2_X] #32772

Conversation

christopheralanwest commented Jan 29, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

christopheralanwest commented Jan 29, 2021

cmsbuild commented Jan 29, 2021 • edited

christopheralanwest commented Jan 29, 2021

christopheralanwest commented Jan 29, 2021

cmsbuild commented Jan 30, 2021

Comparison Summary

christopheralanwest commented Jan 30, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

RelVals-INPUT

Comparison Summary

christopheralanwest commented Feb 1, 2021

cmsbuild commented Feb 1, 2021

silviodonato commented Feb 1, 2021

silviodonato commented Feb 1, 2021

christopheralanwest commented Jan 29, 2021 •

edited

cmsbuild commented Jan 29, 2021 •

edited