New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to cross run number boundaries in IB tests #32786
Add workflow to cross run number boundaries in IB tests #32786
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32786/20953
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/PyReleaseValidation @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32786/21033
|
test parameters
|
Pull request #32786 was updated. @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @christopheralanwest, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8c6ab/12743/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 From the logs for step 2 of workflow 250202.183, we see that the IOV boundary is crossed at the expected location:
|
+Upgrade @christopheralanwest |
+1 the same questions as @srimanob, where would you add 250202.183 in IB? |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #28214 implemented workflow 250202.183, which was the only workflow that would cross run boundaries for tests of run-dependent MC. It was removed a few months later when run-dependent workflows were "cleaned up" in PR #29457. Other run-dependent workflows are intended for use with full relvals and so many lumiblocks must be crossed before changing the run number. Since AlCa would like to foster further development of run-dependent MC, it is very useful to test that IOV boundaries can be crossed in MC without crashing, and I would like to have this workflow back.
I also added an autoCond key
phase1_2018_realistic_rd
with a value corresponding to a MC GT for 2018 run-dependent MC. The time-dependent relvals have been updated to use this key rather than conditions overrides.PR validation:
After running
runTheMatrix.py -l 250202.183
, I checked that the DIGI-PREMIX and RECO files contain events with two different run numbers:This is the expectation given the configuration.
runTheMatrix.py -l 250202.182
also completes successfully.if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and should not be backported.