Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of GEM onlineDQM, backport to CMSSW_11_2_X #32791

Merged
merged 1 commit into from Feb 5, 2021

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Feb 2, 2021

PR description:

We've modified the structure of GEM onlineDQM to make it simpler so that developers and shifters of GEM will have more convenience. For developers, we are planning to unify several modules for GEM; onlineDQM, offlineDQM, validation, and it will be the start of the unification work. For shifters, many summarizing plots are added and mainly displayed; the detail plots will be hidden but can be easily found.

And this PR is a backport of #32792.

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij @hyunyong

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

A new Pull Request was created by @quark2 for CMSSW_11_2_X.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b492f6/12648/summary.html
COMMIT: 738f7e1
CMSSW: CMSSW_11_2_X_2021-02-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32791/12648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@quark2
Copy link
Contributor Author

quark2 commented Feb 3, 2021

Hi all,

we are supposed to see the updates by this PR in the coming MWGR. Because it has a lot of changes on the GEM onlineDQM, I guess I need to report about this in the coming DQM General meeting (on this Friday). Is it okay? Or do I need to do something more?

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 3, 2021

Hi @quark2
I have included you in the agenda for Friday, thanks!
https://indico.cern.ch/event/1005033/

@quark2
Copy link
Contributor Author

quark2 commented Feb 3, 2021

Hi @jfernan2
Great, thanks!

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 4, 2021

+1
Backport tested at P5 in Online DQM

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
(already tested at P5 in Online DQM)

@cmsbuild cmsbuild merged commit 97d3abe into cms-sw:CMSSW_11_2_X Feb 5, 2021
@quark2
Copy link
Contributor Author

quark2 commented Feb 5, 2021

Hi @silviodonato,

I also made a PR to the DQM GUI software [1]. Have you also tested?
(I should inform about this PR already in this thread...)

Best regards,
Byeonghak Ko

[1] dmwm/deployment#1028

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2021

Hi @quark2
We were not aware of this PR, we will test it at P5 right now
I hope you have already tested it on your side, however this would only affect the GUI, the worst thing is some plot not being displayed but no crashes are possible.

@quark2
Copy link
Contributor Author

quark2 commented Feb 5, 2021

Hi @jfernan2,

Sorry for my late notice...
I already tested the PR for GUI and then PRed. Hope the test on your side will be done well.

Best regards,
Byeonghak Ko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants