Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of GEM onlineDQM #32792

Merged
merged 1 commit into from Feb 4, 2021

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Feb 2, 2021

PR description:

We've modified the structure of GEM onlineDQM to make it simpler so that developers and shifters of GEM will have more convenience. For developers, we are planning to unify several modules for GEM; onlineDQM, offlineDQM, validation, and it will be the start of the unification work. For shifters, many summarizing plots are added and mainly displayed; the detail plots will be hidden but can be easily found.

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij @hyunyong

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32792/20962

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

A new Pull Request was created by @quark2 for master.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f89d1d/12649/summary.html
COMMIT: bbdbd62
CMSSW: CMSSW_11_3_X_2021-02-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32792/12649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2752926
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2752893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 4, 2021

+1
Tested at P5 in Online DQM

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants