Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr113x L1T Bug fix : uGT emulator of displaced muons - step2 #32818

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Feb 4, 2021

PR description:

Pr113x L1T : needed for MWGR

Fix uGT emulator of displaced muons (step2) - remove 2ndary check for impact parameter

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32818/21007

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Feb 4, 2021

urgent

@cmsbuild cmsbuild added the urgent label Feb 4, 2021
@rekovic
Copy link
Contributor Author

rekovic commented Feb 4, 2021

please test

@rekovic
Copy link
Contributor Author

rekovic commented Feb 4, 2021

@qliphy and @silviodonato
Please take a note of this 2nd fix of uGT emulator needed for MWGR. Please include it in the IB and the bakckport PR into release for the MWGR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c8c/12715/summary.html
COMMIT: 123d208
CMSSW: CMSSW_11_3_X_2021-02-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32818/12715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 119
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751624
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Feb 5, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 49910c3 into cms-sw:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants