HCAL (HB): propagate RECO updates from Run3 to Phase2

[abdoulline]

PR description:

Several HCAL RECO updates, which are already available for Run3 in 11_2_X, were previously put on hold for Phase2 due to HLT Phase2 TDR studies:

• (HB) RECO pulse shape (Id 208)
• non-0 noise correlation factors (and HBHE: avoid double counting of correlated term #32662 - fix of correlation term accounting in MAHI, in action for non-0 correlations).

Now these changes are propagated to Phase2 (via hardcoded conditions used for Phase2 HCAL).

PR validation:

(1) Sanity checks:
(a) dumping of the relevant conditions (HcalSiPMParameters and HcalRecoParams) shows updated numbers;
(b) simple particle gun Calorimetry scan with Phase2D49 noPU shows expected results:
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/Phase2/11_3_0_pre2_Phase2_D49_updCond_vs_11_3_0_pre2_Phase2_D49_SinglePi/

(2) runTheMatrix.py -l limited is OK

if this PR is a backport

No

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32856/21078

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mariadalfonso, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276cfe/12840/summary.html
COMMIT: 49edf0a
CMSSW: CMSSW_11_3_X_2021-02-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32856/12840/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4020 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2751765
• DQMHistoTests: Total failures: 13912
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2737831
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[yuanchao]

+1

• adding noiseCN param. and change HB pulse shape from 206 to 208.
• WF tests and unit tests all passed
• Static building warnings aren't part of the modification

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1