Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DD4Hep workflows from 13TeV to 14TeV #32857

Merged
merged 2 commits into from Feb 11, 2021

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Feb 9, 2021

This PR moves TTbar and ZMM DD4Hep workflows from 13 TeV to 14 TeV, as discussed today at the ORP meeting. The reason is that 11634.0 is used in the current RelVal production and then we want the corresponding 11634.911. Same thing for 11642.911 which has been moved to 14 TeV 11650.911. The short matrix has been updated accordingly.
The PR has been tested simply with runTheMatrix.py -l 11634.911,11650.911

@silviodonato
Copy link
Contributor Author

please test 11634.911

cc: @cms-sw/simulation-l2 @cms-sw/geometry-l2

@@ -950,7 +950,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
dd4hepGeom+=stepDict[step][k]['--geometry']
stepDict[stepName][k] = merge([{'--geometry' : dd4hepGeom, '--procModifiers': 'dd4hep'}, stepDict[step][k]])
def condition(self, fragment, stepList, key, hasHarvest):
return ((fragment=='TTbar_13' or fragment=='ZMM_13' or fragment=='SingleMuPt10') and '2021' in key) \
return ((fragment=='TTbar_13' or fragment=='TTbar_14' or fragment=='ZMM_13' or fragment=='SingleMuPt10') and '2021' in key) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we won't use dd4hep for run2, perhaps 13 tev workflows aren't very useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have only 11624.911 in pre2, I think it is good to have both 11624.911 and 11634.911 in pre3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agreed with @davidlange6 that 13TeV isn't useful to keep

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2021

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 9, 2021

@cmsbuild please test

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 9, 2021

@silviodonato Thank you for creating this workflow.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d68c5/12808/summary.html
COMMIT: 01b39f0
CMSSW: CMSSW_11_3_X_2021-02-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32857/12808/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2751765
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751742
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@@ -55,7 +55,7 @@
10824.501,
10824.511,
10824.521,
11624.911, 11642.911,
11634.911,11624.911, 11642.911,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviodonato , @cvuosalo could you clarify why we need 13TeV for Run3 scenario? Shall we move everything about DD4HEP to 14TeV (also ZMM)?

@@ -950,7 +950,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
dd4hepGeom+=stepDict[step][k]['--geometry']
stepDict[stepName][k] = merge([{'--geometry' : dd4hepGeom, '--procModifiers': 'dd4hep'}, stepDict[step][k]])
def condition(self, fragment, stepList, key, hasHarvest):
return ((fragment=='TTbar_13' or fragment=='ZMM_13' or fragment=='SingleMuPt10') and '2021' in key) \
return ((fragment=='TTbar_13' or fragment=='TTbar_14' or fragment=='ZMM_13' or fragment=='SingleMuPt10') and '2021' in key) \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agreed with @davidlange6 that 13TeV isn't useful to keep

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 10, 2021 via email

@silviodonato
Copy link
Contributor Author

please test workflows 11634.911, 11650.911

@silviodonato
Copy link
Contributor Author

As you prefer, I've removed the 13TeV workflow, and so I've also updated the short matrix to replace the DD4HEP worflow from 11624.911 to 11634.911. I also updated the ZMM to 14TeV, just to have everything at 14TeV (11642.911 -> 11650.911)

@cmsbuild
Copy link
Contributor

Pull request #32857 was updated. @chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d68c5/12826/summary.html
COMMIT: 53711db
CMSSW: CMSSW_11_3_X_2021-02-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32857/12826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1d68c5/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1d68c5/11650.911_ZMM_14+2021_DD4hep+ZMM_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2536530
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2536507
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@cvuosalo
Copy link
Contributor

The logs from the new workflows look good. They seem to have run correctly.

@silviodonato silviodonato changed the title Addition of DD4Hep TTbar_14TeV workflow Move DD4Hep workflows from 13TeV to 14TeV Feb 11, 2021
@silviodonato
Copy link
Contributor Author

I've updated the PR description. @cms-sw/upgrade-l2 @cms-sw/pdmv-l2 do you have further comments?

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor Author

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants