Remove outdated comments about previous implementation of rpcMatches in Muon.cc

[perrotta]

PR description:

Issue #31783 reported about a possible bug in the implementation of the rpcMatches in DataFormats/MuonReco/src/Muon.cc
During the discussion, it was agreed that the already proposed adjustment did work: what remained to do was to remove the comment lines left in two places of the same code to keep track of the possible bug.

This PR removes those now outdated comment lines, and therefore it fixes #31783

While there, I also removed the useless checks for non emptiness of chamberMatch.rpcMatches, which just duplicate an identical check a few lines above

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32884/21116

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

DataFormats/MuonReco

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @rovere, @trocino, @amagitte, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fb961/12851/summary.html
COMMIT: 0e14c66
CMSSW: CMSSW_11_3_X_2021-02-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32884/12851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1fb961/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750846
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750823
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[perrotta]

+1

• Trivial removal of commented out or useless lines
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1