Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with trend-plotting in payload inspector #32902

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 12, 2021

PR description:

In PR #32404 I introduced a modification to CondCore/Utilities/interface/PayloadInspector.h in order to be able retrieve the list of dead modules in JSON format from the SiStripDetVOff DB record.
The setting of precision(0) was meant to strip off the decimal place from the DetId number (stored as double), but it turns out that applying this change indiscriminately kills all the trend plotting for quantities stored as double and with non vanishing decimal parts. See e.g. this example:

image

I fix the issue by imposing that the setting of the precision is applied only when the number to display has no decimal part to start with.

PR validation:

Run the following command:

getPayloadData.py --plugin pluginBeamSpotOnline_PayloadInspector --plot plot_BeamSpotOnline_HistoryX --tag BeamSpotOnlineTestHLT --time_type Lumi --iovs '{"start_iov": "1458480699408457", "end_iov": "1458480699408459"}' --db Prod --test ;

with this branch and got:

{
    "version": "1.0", 
    "data": [
        {
            "y": -0.070925, 
            "x": 1458480699408457, 
            "y_err": 0
        }, 
        {
            "y": 0.140151, 
            "x": 1458480699408458, 
            "y_err": 0
        }, 
        {
            "y": -0.04356, 
            "x": 1458480699408459, 
            "y_err": 0
        }
    ], 
    "annotations": {
        "x_label": "iov_since", 
        "y_label": "X", 
        "type": "History", 
        "payload_type": "BeamSpotOnlineObjects", 
        "title": "X vs run number"
    }
}

while in vanila CMSSW_11_3_X_2021-02-12-1100 I get

{
    "version": "1.0", 
    "data": [
        {
            "y": 0, 
            "x": 1458480699408457, 
            "y_err": 0
        }, 
        {
            "y": 0, 
            "x": 1458480699408458, 
            "y_err": 0
        }, 
        {
            "y": 0, 
            "x": 1458480699408459, 
            "y_err": 0
        }
    ], 
    "annotations": {
        "x_label": "iov_since", 
        "y_label": "X", 
        "type": "History", 
        "payload_type": "BeamSpotOnlineObjects", 
        "title": "X vs run number"
    }
}

if this PR is a backport please specify the original PR and why you need to backport that PR:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 12, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32902/21131

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 12, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1192/12868/summary.html
COMMIT: e78d46e
CMSSW: CMSSW_11_3_X_2021-02-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32902/12868/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ed1192/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750846
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750823
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Feb 16, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 16, 2021

+1

@cmsbuild cmsbuild merged commit ccbc180 into cms-sw:master Feb 16, 2021
@mmusich mmusich deleted the fixTrendPlottingIssuePayloadInspector branch February 16, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants