New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with trend-plotting in payload inspector #32902
fix issue with trend-plotting in payload inspector #32902
Conversation
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32902/21131
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/Utilities @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed1192/12868/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In PR #32404 I introduced a modification to
CondCore/Utilities/interface/PayloadInspector.h
in order to be able retrieve the list of dead modules in JSON format from theSiStripDetVOff
DB record.The setting of
precision(0)
was meant to strip off the decimal place from theDetId
number (stored as double), but it turns out that applying this change indiscriminately kills all the trend plotting for quantities stored asdouble
and with non vanishing decimal parts. See e.g. this example:I fix the issue by imposing that the setting of the precision is applied only when the number to display has no decimal part to start with.
PR validation:
Run the following command:
with this branch and got:
while in vanila
CMSSW_11_3_X_2021-02-12-1100
I getif this PR is a backport please specify the original PR and why you need to backport that PR: