Add nConstituents to fat jets. #32927

laurenhay · 2021-02-16T19:18:51Z

PR description:

For use with AK8 PF Candidate jet tables.

PR validation:

Trivial inspection. See jetTable.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

#### PR description: For use with AK8 PF Candidate jet tables. #### PR validation: Trivial inspection. See jetTable. #### if this PR is a backport please specify the original PR and why you need to backport that PR: NA

cmsbuild · 2021-02-16T19:23:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32927/21157

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): PUID UL18 for nanoAOD #32887

cmsbuild · 2021-02-16T19:24:07Z

A new Pull Request was created by @laurenhay for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2021-02-18T12:24:42Z

please test

cmsbuild · 2021-02-18T23:45:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7ef7a/12969/summary.html
COMMIT: dc5a998
CMSSW: CMSSW_11_3_X_2021-02-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32927/12969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 80 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2750947
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 156 log files, 37 edm output root files, 37 DQM output files

mariadalfonso

the new variable it's not added in the DQM plot.
suggested to add.

mariadalfonso · 2021-02-19T15:55:07Z

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -471,7 +471,7 @@

 #        btagDeepC = Var("bDiscriminator('pfDeepCSVJetTags:probc')",float,doc="CMVA V2 btag discriminator",precision=10),
 #puIdDisc = Var("userFloat('pileupJetId:fullDiscriminant')",float,doc="Pileup ID discriminant",precision=10),
-#        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),
+        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),
 #        rawFactor = Var("1.-jecFactor('Uncorrected')",float,doc="1 - Factor to get back to raw pT",precision=6),


this extra line rawFactor can be removed as well, since it's added above

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -471,7 +471,7 @@

 #        btagDeepC = Var("bDiscriminator('pfDeepCSVJetTags:probc')",float,doc="CMVA V2 btag discriminator",precision=10),
 #puIdDisc = Var("userFloat('pileupJetId:fullDiscriminant')",float,doc="Pileup ID discriminant",precision=10),
-#        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),
+        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),
 #        rawFactor = Var("1.-jecFactor('Uncorrected')",float,doc="1 - Factor to get back to raw pT",precision=6),


mariadalfonso · 2021-02-19T15:57:02Z

PhysicsTools/NanoAOD/python/jets_cff.py

@@ -471,7 +471,7 @@

 #        btagDeepC = Var("bDiscriminator('pfDeepCSVJetTags:probc')",float,doc="CMVA V2 btag discriminator",precision=10),
 #puIdDisc = Var("userFloat('pileupJetId:fullDiscriminant')",float,doc="Pileup ID discriminant",precision=10),
-#        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),
+        nConstituents = Var("numberOfDaughters()",int,doc="Number of particles in the jet"),


numberOfDaughters() is unsigned int
move int to uint8

silviodonato · 2021-02-23T12:47:50Z

@laurenhay please look at the comments above

cmsbuild · 2021-02-25T18:00:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32927/21276

This PR adds an extra 32KB to repository

cmsbuild · 2021-02-25T18:01:10Z

Pull request #32927 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2021-02-25T18:53:58Z

please test

cmsbuild · 2021-02-25T22:37:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7ef7a/13103/summary.html
COMMIT: 9c3555d
CMSSW: CMSSW_11_3_X_2021-02-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32927/13103/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2941 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2750983
DQMHistoTests: Total failures: 63398
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2687563
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.248 KiB( 36 files compared)
DQMHistoSizes: changed ( 1325.81,... ): 0.124 KiB Physics/NanoAODDQM
Checked 156 log files, 37 edm output root files, 37 DQM output files

mariadalfonso · 2021-02-26T08:32:22Z

Reco comparison results: 2941 differences found in the comparisons

2860 out of 2941 come from the DD4 wf 11634.911 unrelated to this PR

mariadalfonso · 2021-02-26T08:35:51Z

+xpog

cmsbuild · 2021-02-26T08:36:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-02-26T11:57:02Z

+1

Add nConstituents to fat jets.

dc5a998

#### PR description: For use with AK8 PF Candidate jet tables. #### PR validation: Trivial inspection. See jetTable. #### if this PR is a backport please specify the original PR and why you need to backport that PR: NA

cmsbuild added this to the CMSSW_11_3_X milestone Feb 16, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Feb 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 16, 2021

This was referenced Feb 16, 2021

Add nConstituents to fat jets. #32928

Merged

Add nConstituents to fat jets. #32930

Merged

rappoccio mentioned this pull request Feb 17, 2021

Association validation cms-jet/PFNano#30

Open

cmsbuild added tests-started and removed tests-pending labels Feb 18, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 18, 2021

mariadalfonso reviewed Feb 19, 2021

View reviewed changes

Add nConstituents to DQM and delete commented vars

9c3555d

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Feb 25, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2021

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2021

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Feb 26, 2021

cmsbuild added orp-approved and removed orp-pending labels Feb 26, 2021

cmsbuild merged commit c3f3c65 into cms-sw:master Feb 26, 2021

mariadalfonso mentioned this pull request Feb 26, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nConstituents to fat jets. #32927

Add nConstituents to fat jets. #32927

laurenhay commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

silviodonato commented Feb 18, 2021

cmsbuild commented Feb 18, 2021

mariadalfonso left a comment

mariadalfonso Feb 19, 2021

laurenhay Feb 25, 2021

This comment was marked as duplicate.

mariadalfonso Feb 19, 2021

laurenhay Feb 25, 2021

silviodonato commented Feb 23, 2021

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

mariadalfonso commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

mariadalfonso commented Feb 26, 2021 •

edited

mariadalfonso commented Feb 26, 2021

cmsbuild commented Feb 26, 2021

qliphy commented Feb 26, 2021

Add nConstituents to fat jets. #32927

Add nConstituents to fat jets. #32927

Conversation

laurenhay commented Feb 16, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Feb 16, 2021

cmsbuild commented Feb 16, 2021

silviodonato commented Feb 18, 2021

cmsbuild commented Feb 18, 2021

Comparison Summary

mariadalfonso left a comment

Choose a reason for hiding this comment

mariadalfonso Feb 19, 2021

Choose a reason for hiding this comment

laurenhay Feb 25, 2021

Choose a reason for hiding this comment

This comment was marked as duplicate.

mariadalfonso Feb 19, 2021

Choose a reason for hiding this comment

laurenhay Feb 25, 2021

Choose a reason for hiding this comment

silviodonato commented Feb 23, 2021

cmsbuild commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

mariadalfonso commented Feb 25, 2021

cmsbuild commented Feb 25, 2021

Comparison Summary

mariadalfonso commented Feb 26, 2021 • edited

mariadalfonso commented Feb 26, 2021

cmsbuild commented Feb 26, 2021

qliphy commented Feb 26, 2021

mariadalfonso commented Feb 26, 2021 •

edited