Boost 1.75 - Add missing headers (algorithm and memory) and update include locations

[mrodozov]

PR description:

This brings the header for the 4 argument lower_bound, coming from algorithm
It fixes deprecated header warning. There might other warnings

PR validation:

CondFormats/EcalObjects builds with boost 1.75

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32943/21173

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32943/21173/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32943/21173/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32943/21174

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CondFormats/EcalObjects
RecoParticleFlow/PFClusterProducer

@perrotta, @malbouis, @yuanchao, @slava77, @christopheralanwest, @cmsbuild, @jpata, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmarionncern, @lecriste, @rchatter, @felicepantaleo, @cbernet, @tocheng, @lgray, @rovere, @thomreis, @hatakeyamak, @simonepigazzini, @mmusich, @argiro, @seemasharmafnal, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

@mrodozov , should this change work for current boost version ?

[mrodozov]

yes, <boost/function_output_iterator.hpp> is already deprecated in 1.72 but left for backward compat,
and it exists also as <boost/iterator/function_output_iterator.hpp>
boost/range/algorithm/lower_bound.hpp is also there.
it compiles, i tried

[smuzaffar]

please test

[thomreis]

Why boost? EcalMustacheSCParameters.cc and EcalSCDynamicDPhiParameters.cc use std::lower_bound. Should it not rather be #include <algorithm> that is missing?

[cmsbuild]

Pull request #32943 was updated. @perrotta, @malbouis, @yuanchao, @jpata, @slava77, @christopheralanwest, @jmduarte, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @francescobrivio can you please check and sign again.

[perrotta]

please test

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32943/21184

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #32943 was updated. @perrotta, @malbouis, @yuanchao, @jpata, @slava77, @christopheralanwest, @jmduarte, @rekovic, @tlampen, @ggovi, @pohsun, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f0122/12980/summary.html
COMMIT: 4d2f73e
CMSSW: CMSSW_11_3_X_2021-02-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32943/12980/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2750957
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[slava77]

+1

for #32943 4d2f73e

• technical
• compiles and runs without relevant differences
• the PR title and description should be updated to describe what's actually done

[yuanchao]

+1

• adds headers for Boost 1.75 and remove warnings
• matrix tests and unit tests passed
• static build warnings are not part of the PR

[silviodonato]

merge
@cms-sw/db-l2 @cms-sw/l1-l2 please have a look