[DD4hep] Correct name of material for PixelBarrelLayerNCoolTubeHalf volumes

[cvuosalo]

In old DD, PixelBarrelLayerNCoolTubeHalf (where N = 0 to 3) volumes are composed of Bpix_Pipe_Steel_Half. However, with DD4hep, these volumes were composed of Bpix_Pipe_Steel. One way this difference appeared was that the Bpix_Pipe_Steel_Half material cut couple was missing with DD4hep.

Looking in the code, one can see that the tubeMatHalf variable, which sets the material for these volumes, is set to CoolTubeMaterialHalf in the old DD code, while it was set to CoolTubeMaterial in the DD4hep code, which looks like a simple typo.

PR validation:

With this fix, with DD4hep the PixelBarrelLayerNCoolTubeHalf volumes are now properly composed of Bpix_Pipe_Steel_Half, and the corresponding material cut couple also appears, just as in the old DD.
These two configs were used for validation:

SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck_cfg.py
SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py

No backport is needed.

[cvuosalo]

FYI @bsunanda @civanch

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33009/21289

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @ebrondol, @ghugo83, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

type bug-fix

[cvuosalo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e880/13133/summary.html
COMMIT: c0b1c81
CMSSW: CMSSW_11_3_X_2021-02-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33009/13133/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 11725.0DAS Error
• 11925.0DAS Error

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3045 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 74344
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2676616
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cvuosalo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e880/13149/summary.html
COMMIT: c0b1c81
CMSSW: CMSSW_11_3_X_2021-02-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33009/13149/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 11725.0DAS Error
• 11925.0DAS Error

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2970 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 73107
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2677854
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cvuosalo]

Comparison test failure is due to a DAS problem unrelated to this PR.
Comparison test differences for the DD4hep workflow are expected statistical fluctuations due to the tiny change in geometry.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e880/13179/summary.html
COMMIT: c0b1c81
CMSSW: CMSSW_11_3_X_2021-03-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33009/13179/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 11725.0DAS Error
• 11925.0DAS Error

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2970 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 73107
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2677854
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[qliphy]

+1

[qliphy]

merge