Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the simple fix possible. sorry for all this to ended up in released code #3302

Merged
merged 2 commits into from Apr 15, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Apr 11, 2014

No description provided.

@ktf
Copy link
Contributor Author

ktf commented Apr 11, 2014

This is apparently very urgent @davidlange6 objections in bypassing so that we get it in an IB?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

the simple fix possible. sorry for all this to ended up in released code

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #3302 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Apr 11, 2014

the code change looks OK
I haven't tested it yet to see if there are no downstream effects (anyone seeing id=0 killing the jobs just as well).
Considering that Vincenzo doesn't see a crash anymore and if you nee to build 70X patch now, feel free to go ahead and bypass.

@davidlange6
Copy link
Contributor

no rush - the agr is done
On Apr 11, 2014, at 5:39 PM, Slava Krutelyov notifications@github.com wrote:

the code change looks OK
I haven't tested it yet to see if there are no downstream effects (anyone seeing id=0 killing the jobs just as well).
Considering that Vincenzo doesn't see a crash anymore and if you nee to build 70X patch now, feel free to go ahead and bypass.


Reply to this email directly or view it on GitHub.

@slava77
Copy link
Contributor

slava77 commented Apr 11, 2014

+1

#3302 eaf38d0

as expected, fixes the problem in AGR reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1255.html

confirmed the crash is going away for wf 1000.0 and file /store/data/Commissioning2014/MinimumBias/RAW/v1/000/220/820/00000/A8DDCB7F-70BF-E311-99FC-02163E00EA35.root

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Apr 15, 2014
the simple fix possible. sorry for all this to ended up in released code
@davidlange6 davidlange6 merged commit 3d60801 into cms-sw:CMSSW_7_0_X Apr 15, 2014
@VinInn VinInn deleted the EgammaTowerIsolationMess branch July 13, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants