Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop type specification in RecoVertex #33034

Merged
merged 1 commit into from Mar 3, 2021
Merged

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Mar 2, 2021

PR description:

Update the safer syntax for existing parameter :

  • drop type specifications where the original parameter exists.
    (previous PRs for RecoVertex is PR#31784 )

In this PR, one file changed.
RecoVertex/AdaptiveVertexFinder 1 file

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild cmsbuild changed the base branch from CMSSW_11_3_X to master March 2, 2021 15:01
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

@jeongeun, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33034/21330

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoVertex/AdaptiveVertexFinder

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @makortel, @smoortga, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @JyothsnaKomaragiri, @ebrondol, @ferencek, @andrzejnovak, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-540bac/13200/summary.html
COMMIT: 17cfaf5
CMSSW: CMSSW_11_3_X_2021-03-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33034/13200/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2974 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 73113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2677848
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2021

+1

  • Technical
  • Jenkins tests pass with no relevant differences wrt baseline (random differences in 11634.911 are a recent known general issue)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 3, 2021

+1

@cmsbuild cmsbuild merged commit 7bb55f4 into cms-sw:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants