Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Reorganizing layer cluster plots into subfolders #33063

Merged
merged 7 commits into from Mar 4, 2021

Conversation

Xingfu23
Copy link
Contributor

@Xingfu23 Xingfu23 commented Mar 4, 2021

PR description:

The plots in the plots folder contain layer cluster plots that cannot be load or viewed in DQM GUI due to the enormous number of plots in a single layer cluster plot folder. We reorganized the layer cluster folder into subfolders so that we can check the relevant plots in DQM GUI but also have a nicer structure of the output plots.

We expect there is no change in DQM files neither in size or memory as no new histograms are created or deleted.

PR validation:

We have check with a ttbar workflow and plots are visible. Here is our website testing result
https://xisu.web.cern.ch/xisu/HGCValid_hgcalLayerClusters_Plots/

@apsallid @rovere @felicepantaleo @ebrondol @lecriste

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33063/21371

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

A new Pull Request was created by @Xingfu23 (XingFu) for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 4, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-384759/13270/summary.html
COMMIT: fb808aa
CMSSW: CMSSW_11_3_X_2021-03-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33063/13270/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2869 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2731083
  • DQMHistoTests: Total failures: 64469
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2666592
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 260.163 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 86.721 KiB HGCAL/HGCalValidator
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a43633b into cms-sw:master Mar 4, 2021
@rovere
Copy link
Contributor

rovere commented Mar 5, 2021

@Xingfu23 thanks a lot for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants