correct Buildfiles in DataFormats

[davidlange6]

Usual automated script for finding missing dependencies..

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33096/21422

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/Alignment
DataFormats/BTauReco
DataFormats/BeamSpot
DataFormats/CSCDigi
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
DataFormats/CTPPSReco
DataFormats/CaloRecHit
DataFormats/CastorReco
DataFormats/EcalDigi
DataFormats/EcalRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/EgammaTrackReco
DataFormats/FP420Cluster
DataFormats/FTLDigi
DataFormats/GEMDigi
DataFormats/GEMRecHit
DataFormats/GeometrySurface
DataFormats/GsfTrackReco
DataFormats/HGCDigi
DataFormats/HGCRecHit
DataFormats/HGCalReco
DataFormats/HLTReco
DataFormats/HcalCalibObjects
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/Histograms
DataFormats/JetReco
DataFormats/L1TCalorimeterPhase2
DataFormats/L1TGlobal
DataFormats/L1THGCal
DataFormats/L1TMuon
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
DataFormats/LTCDigi
DataFormats/METReco
DataFormats/Math
DataFormats/MuonReco
DataFormats/MuonSeed
DataFormats/OnlineMetaData
DataFormats/ParticleFlowCandidate
DataFormats/ProtonReco
DataFormats/RPCDigi
DataFormats/RecoCandidate
DataFormats/SiPixelCluster
DataFormats/SiPixelDetId
DataFormats/SiPixelRawData
DataFormats/SiStripCluster
DataFormats/SiStripCommon
DataFormats/Streamer
DataFormats/TauReco
DataFormats/TestObjects
DataFormats/TrackCandidate
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
DataFormats/TrajectoryState
DataFormats/VertexReco

@andrius-k, @christopheralanwest, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @smorovic, @smuzaffar, @Dr15Jones, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @kmaeshima, @emeschi, @srimanob, @rvenditti can you please review it and eventually sign? Thanks.
@erikbutz, @emilbols, @gouskos, @echabert, @felicepantaleo, @forthommel, @hatakeyamak, @robervalwalsh, @rappoccio, @sviret, @argiro, @jshlee, @wddgit, @OzAmram, @pfs, @thomreis, @mbluj, @ahinzmann, @lgray, @abbiendi, @varuns23, @seemasharmafnal, @jhgoh, @mmarionncern, @dildick, @smoortga, @sethzenz, @JyothsnaKomaragiri, @makortel, @threus, @watson-ij, @amagitte, @jdolen, @jbsauvan, @cericeci, @ferencek, @battibass, @dkotlins, @pieterdavid, @jainshilpi, @apsallid, @vandreev11, @Sam-Harper, @cbernet, @tocheng, @VinInn, @cseez, @gpetruc, @nhanvtran, @gkasieczka, @rovere, @schoef, @alesaggio, @mmusich, @ptcox, @abdoulline, @fabiocos, @clelange, @kreczko, @jdamgov, @tvami, @HuguesBrun, @rchatter, @trocino, @jan-kaspar, @swozniewski, @Fedespring, @calderona, @simonepigazzini, @sobhatta, @lecriste, @afiqaize, @dinyar, @mariadalfonso, @amarini, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-120100/13323/summary.html
COMMIT: 1d84bb0
CMSSW: CMSSW_11_3_X_2021-03-07-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33096/13323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-120100/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-120100/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2849195
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2849172
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files

[makortel]

+1

[jfernan2]

+1

[jfernan2]

+1

[Martin-Grunewald]

+1

[smorovic]

+1

[civanch]

+1

[yuanchao]

+1

• only BuildFile.xml as well as one header file are modified
• matrix tests and unit tests all passed
• static build warnings are not due to the PR

[silviodonato]

@cms-sw/core-l2 @cms-sw/l1-l2 can we merge this PR?

[smuzaffar]

+core

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1