New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NanoAOD markdown reports #33097
Add NanoAOD markdown reports #33097
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33097/21424
|
A new Pull Request was created by @deinal (Daniel Holmberg) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf541/13332/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@deinal have you already discussed about this at the @cms-sw/xpog-l2 meeting? |
@silviodonato No, I haven't. I'm not part of that team so I can't open the link. |
@gouskos @mariadalfonso - Are you fine with this addition? |
kind reminder @cms-sw/xpog-l2 |
kindly ping @cms-sw/xpog-l2 |
enable profiling |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf541/15938/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf541/16154/summary.html Comparison SummarySummary:
|
please test |
(cms-sw/cms-bot#1567 is merged) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbf541/16587/summary.html Comparison SummarySummary:
|
@cms-sw/xpog-l2 we have finally the file size comparison for NanoAOD (11834.21). You have to enable the profiling (see #33097 (comment)) |
Hi @mariadalfonso, |
@kirschen |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
I've added the ability to produce content and collection-size reports of NanoAOD root files as markdown files. The script only produced html output before my changes, but markdown files are far more convenient if you want to include these report files in version control or display them in a repository on e.g. GitHub/GitLab.
Example content report:
https://github.com/deinal/nanoaod-reports/blob/main/collection-description.md
Example size report:
https://github.com/deinal/nanoaod-reports/blob/main/collection-size.md
PR validation:
My changes don't affect anything else. The script works on lxplus after executing cmsenv.