New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data vs emulator plots in CSC DQM [11_2_X] #33120
Data vs emulator plots in CSC DQM [11_2_X] #33120
Conversation
A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_11_2_X. It involves the following packages: DQM/L1TMonitor @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d32746/13549/summary.html Comparison SummarySummary:
|
Is it required for the MWGR? |
The answer was in the PR description |
At least this comment of the master version of the PR still holds here too: |
Pull request #33120 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
Backported 4 commits from the 11_3_X PR. |
@jfernan2 Can you run the tests, please? |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
For these newly added WFs I need to insert the GEM pad producer and GEM pad cluster producer into the L1T sequence for DQM. That is until the GEM cluster unpackers become available. Once they are available in the unpacker sequence, I can take them out. In any case, this can be fixed easily.
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
Pull request #33120 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
1 similar comment
Pull request #33120 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
Pull request #33120 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
Approximate backport of the 11_3_X version. GEM-CSC integrated local trigger switched off (since not yet at P5). I ran the integration test successfully.
|
Output from
Failed tests are
|
Why the backport is now approximate? Can you elaborate a bit? Thanks |
The GEM-CSC integrated local trigger emulator runs by default in run-3 eras in CMSSW_11_3_X. But the integrated local trigger firmware has not yet been deployed at P5. So in the L1T DQM re-emulation sequence in CMSSW_11_2_X I turned the integrated local trigger off. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d32746/13995/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
With this PR we add histograms for CSC trigger primitives (ALCT, CLCT, LCT) data vs emulator comparisons. There are 1D histograms for each TP property and "data-emulator" plots - which ideally are empty. Backport needed for next MWGRs.
PR validation:
Code compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #33085