Fix G4 logical volumes assignments to production cuts regions with DD4hep

[ghugo83]

Fix the remaining discrepancies in G4 logical volumes assignments to production cuts regions with DD4hep.
These discrepancies were stemming from reflected volumes.
Reflected volumes need to benefit from a special treatment in DD4hep.

This is now addressed, and together with #33101:
The production cuts assignments are not absolutely identical between DDD and DD4hep: 839 roots are assigned to production cuts regions.

NB: I also had a branch where a container already containing the G4 reflected volumes is passed to the production cuts constructor. This complicates the interface though, and has absolutely no impact on perf (less than ~0.01 s in initialization loop), hence did not go for that option.

@civanch @cvuosalo @ianna

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33164/21552

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ghugo83]

NB: Production cut regions are also identical between DDD and DD4hep.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4886b/13475/summary.html
COMMIT: 0544d91
CMSSW: CMSSW_11_3_X_2021-03-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33164/13475/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1