clean includes in PhotonMIPHaloTagger.h

[davidlange6]

noticed as they lead to errors in the modules IB (not really sure why..)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33169/21568

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

RecoEgamma/PhotonIdentification

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @varuns23, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcd576/13484/summary.html
COMMIT: f43a7c4
CMSSW: CMSSW_11_3_X_2021-03-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33169/13484/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635064
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[davidlange6]

"598 598 595 556 117 41 3 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed" - I'm not sure I see the problem reported?

[perrotta]

please test

[perrotta]

@davidlange6 since you are cleaning the includes in this class, you can maybe also consider the following:

• "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h" can now be removed from PhotonMIPHaloTagger.cc
• I would say also "DataFormats/HcalRecHit/interface/HcalRecHitCollections.h"
• Also EcalChannelStatusRcd.h and EcalSeverityLevelAlgoRcd.h can be removed from being include'd in PhotonMIPHaloTagger.cc
• Probably several other include's can be removed from PhotonMIPHaloTagger.cc, e.g.
  • "DataFormats/BeamSpot/interface/BeamSpot.h"
  • All EgammaIsolationAlgos
  • "DataFormats/EgammaReco/interface/BasicCluster.h"
  • "DataFormats/EgammaReco/interface/BasicClusterFwd.h"
  • "DataFormats/EgammaReco/interface/SuperCluster.h"
  • "DataFormats/TrackReco/interface/Track.h"
  • "DataFormats/TrackReco/interface/TrackFwd.h"
  • "DataFormats/EgammaCandidates/interface/GsfElectron.h"
  • "DataFormats/EgammaCandidates/interface/GsfElectronFwd.h"
  • "CommonTools/Utils/interface/StringToEnumValue.h"
  • "DataFormats/EcalDetId/interface/EEDetId.h"
  • All "Geometry" ones (two of them are also repeated twice)
• <string> can be removed both from .h and from .cc
• I would add an #include <vector> in the header, instead

[davidlange6]

Hi @perrotta - I’ll have to leave a general cleanup of this class to the experts...

…

On Mar 15, 2021, at 11:12 AM, perrotta ***@***.***> wrote: @davidlange6 since you are cleaning the includes in this class, you can maybe also consider the following: • "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h" can now be removed from PhotonMIPHaloTagger.cc • I would say also "DataFormats/HcalRecHit/interface/HcalRecHitCollections.h" • Also EcalChannelStatusRcd.h and EcalSeverityLevelAlgoRcd.h can be removed from being include'd in PhotonMIPHaloTagger.cc • Probably several other include's can be removed from PhotonMIPHaloTagger.cc, e.g. • "DataFormats/BeamSpot/interface/BeamSpot.h" • All EgammaIsolationAlgos • "DataFormats/EgammaReco/interface/BasicCluster.h" • "DataFormats/EgammaReco/interface/BasicClusterFwd.h" • "DataFormats/EgammaReco/interface/SuperCluster.h" • "DataFormats/TrackReco/interface/Track.h" • "DataFormats/TrackReco/interface/TrackFwd.h" • "DataFormats/EgammaCandidates/interface/GsfElectron.h" • "DataFormats/EgammaCandidates/interface/GsfElectronFwd.h" • "CommonTools/Utils/interface/StringToEnumValue.h" • "DataFormats/EcalDetId/interface/EEDetId.h" • All "Geometry" ones (two of them are also repeated twice) • <string> can be removed both from .h and from .cc • I would add an #include <vector> in the header, instead — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcd576/13501/summary.html
COMMIT: f43a7c4
CMSSW: CMSSW_11_3_X_2021-03-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33169/13501/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635064
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass
• (Further cleaning in the same package could be the target for a future PR)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1