Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig7 2 2 settings update 10 6 #33228

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

PR description:

Update the Herwig settings blocks so these work with the current version of Herwig. Also update the Powheg+Herwig test to use these blocks, and add tests/examples for Madgraph+Herwig with both mlm and FxFx merging. Will add documentation on how to use these on the Herwig interface twiki: https://twiki.cern.ch/twiki/bin/viewauth/CMS/Herwig7Interface

PR validation:

Checked that all three examples work (Powheg example is runTheMatrix workflow 535)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33227 for use in UL production

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2021

A new Pull Request was created by @Dominic-Stafford for CMSSW_10_6_X.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @mkirsano, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Mar 19, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb52d5/13634/summary.html
COMMIT: b26f204
CMSSW: CMSSW_10_6_X_2021-03-19-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33228/13634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215541
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215205
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Mar 23, 2021

ping @cms-sw/generators-l2

@SiewYan
Copy link
Contributor

SiewYan commented Mar 23, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

Backport of #33227

@qliphy
Copy link
Contributor

qliphy commented Mar 24, 2021

+1

@cmsbuild cmsbuild merged commit 6edfd0a into cms-sw:CMSSW_10_6_X Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants