Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3 sim83 Attempt to unify the file definitions between FullSim and FastSim #33233

Merged
merged 5 commits into from Mar 23, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Attempt to unify the file definitions between FullSim and FastSim

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33233/21677

  • This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33233/21678

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

FastSimulation/Calorimetry
Geometry/HcalSimData
SimG4CMS/Calo
SimG4Core/Application

@ssekmen, @Dr15Jones, @lveldere, @makortel, @cvuosalo, @civanch, @ianna, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @matt-komm, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ProbMax = cms.double(1.0),
CFibre = cms.double(0.5),
OnlyLong = cms.bool(True)
HFShowerBlock = HFShowerBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to "long distance interaction" that is very confusing in most cases. If anyone does e.g. g4SimHits.HFShower.HFShowerBlock.ProbMax = 0.1, that change will be visible here as well (because the HFShowerBlock PSet object is the same).

We typically advise against that behavior and do

Suggested change
HFShowerBlock = HFShowerBlock
HFShowerBlock = HFShowerBlock.clone()

instead.

If you want to be able to set value in HFShowerBlock PSet once and have the change to propagate to both here and g4SimHits, best would be to do

Suggested change
HFShowerBlock = HFShowerBlock
HFShowerBlock = cms.PSet(refToPSet_ = cms.string("HFShowerBlock"))

and make sure the top-level HFShowerBlock gets attached to cms.Process (as it current does). Then the intention is clear, and the connection is visible e.g. edmConfigDump. The C++ side doesn't need any change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda , let us do like this

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33233/21684

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33233 was updated. @ssekmen, @Dr15Jones, @lveldere, @makortel, @cvuosalo, @civanch, @ianna, @mdhildreth, @cmsbuild, @sbein can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33233/21698

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33233 was updated. @ssekmen, @Dr15Jones, @lveldere, @makortel, @cvuosalo, @civanch, @ianna, @mdhildreth, @cmsbuild, @sbein can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34b748/13663/summary.html
COMMIT: 0de7d4d
CMSSW: CMSSW_11_3_X_2021-03-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33233/13663/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2639935
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2639894
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Mar 23, 2021

@sbein , your sign should be first

@sbein
Copy link
Contributor

sbein commented Mar 23, 2021

+1

@civanch
Copy link
Contributor

civanch commented Mar 23, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants