Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test code in EcalDeadChannelRecoveryAlgos. #3325

Merged
merged 1 commit into from Apr 16, 2014

Conversation

dmitrijus
Copy link
Contributor

One last cleanup for #3247 .
Only changes the test code (refactor and consumes migration), should not break anything.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_1_X.

Refactor test code in EcalDeadChannelRecoveryAlgos.

It involves the following packages:

RecoLocalCalo/EcalDeadChannelRecoveryAlgos

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2014

+1

for #3325 0946280
checked in CMSSW_7_1_X_2014-04-14-0200 (test area sign344)
no regressions

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 16, 2014
Reco -- Refactor test code in EcalDeadChannelRecoveryAlgos.
@ktf ktf merged commit e8f781b into cms-sw:CMSSW_7_1_X Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants