New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca182 Update some of the calibration code/scripts using IsoTracks for HCAL #33301
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33301/21825
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33301/21826
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Calibration/HcalCalibAlgos @malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2645fd/13850/summary.html Comparison SummarySummary:
|
@bsunanda looks like unwanted change (bool to "double") ? In HcalIsoTrackStudy.cc
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33301/21855
|
Pull request #33301 was updated. @malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2645fd/13900/summary.html Comparison SummarySummary:
|
@malbouis, @yuanchao, @christopheralanwest Can you approve this? |
@malbouis, @yuanchao, @christopheralanwest @silviodonato Can you approve and merge this PR? |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update some of the calibration code/scripts using IsoTracks for HCAL
PR validation:
Tested by applying the codes to Run3 MC sets
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special