Migrate module configurations in {JetMETCorrections,PhysicsTools} to use automatically generated cfi default/reference configurations

[jeongeun]

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.

In this PR, 4 files changed. (The reference PR is PR#33207 )

• commit 1 :
  Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefaylt.clone() )
  Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safty.

• commit 2 :
  Remove the duplicated parameters that are exactly the same value in cfipython reference.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_3_X, the basic test all passed in the CMSSW PR instructions.

@camclean @alefisico please check and confirm if this update is acceptable.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33307/21836

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b779fa/13870/summary.html
COMMIT: 3e6ac69
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33307/13870/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640841
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2640818
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

I am not able to find a PFCandPtrProjector plugin anywhere in CMSSW, not even in 9_1_X (which is the release where this config was introduced with #18165)

@mmarionncern and @zdemirag: do you remember where that plugin was defined?

By the way, isn't this config already obsolete (and candidate for possible deletion)? corMETFromMuonAndEG is only called by PhysicsTools/PatAlgos/python/slimming/extraSlimmedMETs_MuEGFixMoriond2017.py, which according to the name is quite likely not needed any more. (Moreover, muCorrection=False in there , and therefore this muonRecoMitigation wasn't actually ever accessed even from there...)

[mariadalfonso]

@kirschen @lathomas @ahinzmann (as mmarionncern original developer left the field)

[slava77]

perhaps it's a more general XPOG question (as it was initially introduced via XPOG): do we still need to support the muon reco duplicate mitigation?
If not, it could be dropped.

[alefisico]

Hi all
I dont see any obvious wrongdoing in the PR. Maybe a small comment in PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py. Isn't it too generic to call this module as just _mod?:

import CommonTools.CandAlgos.candPtrProjector_cfi as _mod

I might call it something more meaningful for future developments.

[perrotta]

Hi all
I dont see any obvious wrongdoing in the PR. Maybe a small comment in PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py. Isn't it too generic to call this module as just _mod?:

import CommonTools.CandAlgos.candPtrProjector_cfi as _mod

I might call it something more meaningful for future developments.

@alefisico that _mod is just a temporary only used to import the actual configuration to be cloned and modified: as such one could even call it temp or whatever else, and anyhow the scope will remain limited to this file

[perrotta]

@kirschen @lathomas @ahinzmann @mariadalfonso : could you please verify if we still need to support the muon reco duplicate mitigation? If so, my question about the possible location of the PFCandPtrProjector plugin remains; if not, one could think about cleaning the corresponding configs in CMSSW.

Since this PR is technically correct, once clarified what above we could even accept it in the release, and open a github issue to keep track of the proposed further cleanup and/or adjustments: but I would like to profit of this fortuitous occasion to clarify this point, before signing the PR and forgetting it still for a while.

[perrotta]

+1

• Technical migration, following the directions outlined in the PR description
• Jenkins tests pass and show no differences in outputs
• While reviewing this PR it was evident that there is some unused code in CMSSW that could be more conveniently be dropped, instead to keep maintaining it: issue Do we still need to support the muon reco duplicate mitigation in PhysicsTools/PatUtils? #33406 has been opened to keep track of it

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1