Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport for 11_2_X) Add displaced muon info from EMTF to RegionalMuonCand (un)packing and to uGMT DQM #33311

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 31, 2021

PR description:

This PR adds awareness of displaced muon information from EMTF to the RegionalMuonCand (un)packers. It also adds plots for these data to the uGMT DQM.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #33146 on request of @rekovic

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_11_2_X.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f875ca/13880/summary.html
COMMIT: 5fe1231
CMSSW: CMSSW_11_2_X_2021-03-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33311/13880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 13
  • DQMHistoTests: Total successes: 2527436
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 37.214 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 8.910 KiB L1T/L1TStage2uGMT
  • DQMHistoSizes: changed ( 11634.0,... ): 3.496 KiB L1TEMU/L1TdeStage2uGMT
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Tested succesfully at Online DQM@P5

@dinyar
Copy link
Contributor Author

dinyar commented Mar 31, 2021

Hi @jfernan2, @rekovic,

Please hold on merging this for the moment, I'd like to be sure it's fine for @boudoul.

Cheers,
Dinyar

@rekovic
Copy link
Contributor

rekovic commented Apr 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30ab0bf into cms-sw:CMSSW_11_2_X Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants