New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring RootFile #33315
Refactoring RootFile #33315
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33315/21848
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: IOPool/Input @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: CMS Clang-Tidy warnings: There are 20 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/llvm-analysis/cmsclangtidy.txt for details. Comparison SummarySummary:
|
@gartung It looks like the clang-tidy "files in this PR only" filter would include files changed in the other PRs (that have been merged already). Would it be feasible to ignore the files changed in the other PRs? |
Yes. |
@smuzaffar How do I get the files changed by just the current PR. The changed-files file contains all of the files other PR merge with the current PR. |
@gartung , you can do something like https://github.com/cms-sw/cms-bot/blob/master/run-pr-code-checks#L43 to get the files changed by the PR |
- Better handling of EventAuxiliary. - Avoid driving the use of EventAuxiliary via a side-effect. - Cache of EventAuxiliary read only accessed in one function. - Replaced member data with function argument passing.
0726496
to
c3143e7
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33315/21857
|
Pull request #33315 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13908/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
All framework unit tests pass.
resolves makortel/framework#105