Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring RootFile #33315

Merged
merged 1 commit into from Apr 1, 2021
Merged

Refactoring RootFile #33315

merged 1 commit into from Apr 1, 2021

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Mar 31, 2021

PR description:

  • Better handling of EventAuxiliary.
    • Avoid driving the use of EventAuxiliary via a side-effect.
    • Cache of EventAuxiliary read only accessed in one function.
  • Replaced member data with function argument passing.

PR validation:

All framework unit tests pass.

resolves makortel/framework#105

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33315/21848

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

IOPool/Input

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/summary.html
COMMIT: 0726496
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33315/13887/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/git-merge-result

CMS Clang-Tidy warnings: There are 20 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13887/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640841
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2640812
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@gartung It looks like the clang-tidy "files in this PR only" filter would include files changed in the other PRs (that have been merged already). Would it be feasible to ignore the files changed in the other PRs?

@gartung
Copy link
Member

gartung commented Mar 31, 2021

Yes.

@gartung
Copy link
Member

gartung commented Mar 31, 2021

@smuzaffar How do I get the files changed by just the current PR. The changed-files file contains all of the files other PR merge with the current PR.

@smuzaffar
Copy link
Contributor

@gartung , you can do something like https://github.com/cms-sw/cms-bot/blob/master/run-pr-code-checks#L43 to get the files changed by the PR

- Better handling of EventAuxiliary.
   - Avoid driving the use of EventAuxiliary via a side-effect.
   - Cache of EventAuxiliary read only accessed in one function.
- Replaced member data with function argument passing.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33315/21857

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33315 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0280b8/13908/summary.html
COMMIT: c3143e7
CMSSW: CMSSW_11_3_X_2021-03-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33315/13908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2640841
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2640818
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Apr 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 1, 2021

+1

@cmsbuild cmsbuild merged commit 5eea7db into cms-sw:master Apr 1, 2021
@Dr15Jones Dr15Jones deleted the improveRootFile branch April 2, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor edm::RootFile
6 participants