Throw when no resolution fits are available in ObjectResolutionCalc

[perrotta]

PR description:

Throw when no resolution fits are available, instead of just issuing a LogError (and crash afterwards when attempting to access the resoFile_ with its null pointer).

Also profit for some (minor) clean up: others would be needed, in particular for the method etaBin(...), which doesn't seem to be used any more though.

PR validation:

It builds.
No changes expected

[perrotta]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33316/21849

• This PR adds an extra 16KB to repository

[perrotta]

please test

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

PhysicsTools/PatUtils

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @schoef, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46bda0/13888/summary.html
COMMIT: db40450
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33316/13888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640841
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2640800
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Technical
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1