Fix non-optimized builds of SiStripApvGain_PayloadInspector.cc #33321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
When built with optimization off and debugging enabled via
USER_CXXFLAGS="-g -O0" scram b
,SiStripApvGain_PayloadInspector.cc
fails to build with the diagnostic that control reaches end of non-void function:This PR adds the missing return statement. Presumably this is somehow optimized out in normal builds.
PR validation:
It compiles and is the very model of a trivial technical change.