PPS Pixel charge share bug fix

[fabferro]

PR description:

This PR fixes the issue #33292 .
The pixels on the edge of the sensor were not treated correctly.
This PR manages to skip the hits in the unsensitive region of the detector and provides correct dimensions of the sensor itself and of the edge pixels.

PR validation:

PPS Pixel digi plots were produced. Very small expected differences in the hits at the edge of the detector.
No more negative array indexes or out of bounds ones.
Tests done with 11846 wf.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport foreseen.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33329/21879

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

SimPPS/PPSPixelDigiProducer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2979c5/13982/summary.html
COMMIT: 9d30a11
CMSSW: CMSSW_11_3_X_2021-04-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33329/13982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2640839
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1