L1T Bugfix for Quad Muon OS condition

[cecilecaillol]

(cherry picked from commit 3d5a10e)

PR description:

This PR is a bug-fix for the uGT emulator. The uGT firmware requires at least 1 pair of OS muons for Quad Muons. The bug in the uGT emulator corresponded to a requirement of exactly 2 OS pairs of muons, which disagreed with firmware. This PR fixes that bug so that the emulator only requires at least 1 pair of OS muons for Quad Muons.

No changes in output are expected.

PR validation:

This PR has been validated by the following:
(1) confirming that all code changes compile correctly using l1t-integration-CMSSW_11_2_0 with tag l1t-integration-v105.3
(2) confirming that all code changes execute properly by producing test vectors
(3) confirming that the bug-fix is correct by comparing the emulator results in the test vectors with the uGT firmware.

if this PR is a backport please specify the original PR and why you need to backport that PR:

cms-l1t-offline#894

@rekovic @cavana

[cmsbuild]

@cecilecaillol, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33346/21924

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33346/21924/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33346/21924/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33346/21925

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-252fbc/14053/summary.html
COMMIT: ece4276
CMSSW: CMSSW_11_3_X_2021-04-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33346/14053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2640839
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[silviodonato]

+1