Remove a dead initialization, and a few other cleanings in EcalTPGParamBuilder

[perrotta]

PR description:

Starting from a dead initialization (of the base local variable) reported by the static analyzer, a few additional rather trivial clean ups in the code that jumped to my eyes were also implemented.

PR validation:

It builds.
No changes expected.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33372/21962

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @rekovic, @tlampen, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ce3/14095/summary.html
COMMIT: 5de8f7d
CMSSW: CMSSW_11_3_X_2021-04-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33372/14095/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ce3/14095/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865483
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• code cleaned up on initialization and branch logic as this PR described
• matrix tests and unit tests all passed
• CLang tidy and build warnings on esConsumes migration on EcalTPGParamBuilder.cc and EcalTPGDBCopy.cc though not the purpose of this PR (?).

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1