New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TkDQM remove getTH1() #33383
TkDQM remove getTH1() #33383
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33383/21981
|
A new Pull Request was created by @sayanchatterjee38 (SAYAN CHATTERJEE) for master. It involves the following packages: DQM/SiStripMonitorCluster @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@sayanchatterjee38 can you please add yourself and your github username to the corresponding e-group? |
please test |
Hi @jfernan2 , Yes. I have added myself with my github username in the e-group. I am waiting for approval. Here is the link: https://e-groups.cern.ch/e-groups/EgroupsAddNewMember.do |
Sorry @sayanchatterjee38 but the link you send is not working, what's the name of the e´-group ? |
Sorry @jfernan2, E-group Name: cms-dqm-offline-developers-l1t (Static) |
L1T? But your changes in this PR are for SiStrip, is this correct? |
Hi @jfernan2 , |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-443a38/14136/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Title: TkDQM : Remove usage of getTH1() from monitor element.
PR description:
The aim of this PR is to remove instances of getTH1() calls from MonitorElements inside TkDQM packages and use functions available from MEs instead.
Links of last two presentations in TkDQM bi-weekly meeting:
https://indico.cern.ch/event/992934/#b-407706-tracker-dqm
https://indico.cern.ch/event/1000804/#b-407716-tracker-dqm
PR validation:
Checks done with workflow 136.892 and no changes are observed.
If this PR is a backport please specify the original PR and why you need to backport that PR:
NA