Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkDQM remove getTH1() #33383

Merged
merged 1 commit into from Apr 10, 2021
Merged

TkDQM remove getTH1() #33383

merged 1 commit into from Apr 10, 2021

Conversation

sayanchatterjee38
Copy link
Contributor

Title: TkDQM : Remove usage of getTH1() from monitor element.

PR description:
The aim of this PR is to remove instances of getTH1() calls from MonitorElements inside TkDQM packages and use functions available from MEs instead.

Links of last two presentations in TkDQM bi-weekly meeting:

https://indico.cern.ch/event/992934/#b-407706-tracker-dqm

https://indico.cern.ch/event/1000804/#b-407716-tracker-dqm

PR validation:
Checks done with workflow 136.892 and no changes are observed.

If this PR is a backport please specify the original PR and why you need to backport that PR:

NA

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33383/21981

  • This PR adds an extra 68KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

A new Pull Request was created by @sayanchatterjee38 (SAYAN CHATTERJEE) for master.

It involves the following packages:

DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorSummary
DQM/SiStripMonitorTrack

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

@sayanchatterjee38 can you please add yourself and your github username to the corresponding e-group?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Tracker_SiStrips_and_Pixels
Thanks

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

please test

@sayanchatterjee38
Copy link
Contributor Author

@sayanchatterjee38 can you please add yourself and your github username to the corresponding e-group?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Tracker_SiStrips_and_Pixels
Thanks

Hi @jfernan2 , Yes. I have added myself with my github username in the e-group. I am waiting for approval. Here is the link: https://e-groups.cern.ch/e-groups/EgroupsAddNewMember.do
Thank you.

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

Sorry @sayanchatterjee38 but the link you send is not working, what's the name of the e´-group ?

@sayanchatterjee38
Copy link
Contributor Author

Sorry @sayanchatterjee38 but the link you send is not working, what's the name of the e´-group ?

Sorry @jfernan2, E-group Name: cms-dqm-offline-developers-l1t (Static)
please go to the corresponding link,
link: https://e-groups.cern.ch/e-groups/Egroup.do?egroupName=cms-dqm-offline-developers-l1t&tab=3
Thank you.

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

E-group Name: cms-dqm-offline-developers-l1t (Static)

L1T? But your changes in this PR are for SiStrip, is this correct?

@sayanchatterjee38
Copy link
Contributor Author

E-group Name: cms-dqm-offline-developers-l1t (Static)

L1T? But your changes in this PR are for SiStrip, is this correct?

Hi @jfernan2 ,
Yes, you are correct. Our changes in the PR are for SiStrip. Sorry! That was my mistake! It should be the Tracker.
E-group Name: E-group: cms-dqm-offline-developers-tracker (Static)
I have added myself with my github username in the tracker e-group. I am waiting for the approval. Here is the link:
https://e-groups.cern.ch/e-groups/Egroup.do?egroupName=cms-dqm-offline-developers-tracker&tab=3
Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-443a38/14136/summary.html
COMMIT: 40747a2
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33383/14136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2865477
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eed25cf into cms-sw:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants