Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update histogram title and binning in CSC validation #33385

Merged
merged 1 commit into from Apr 10, 2021
Merged

Update histogram title and binning in CSC validation #33385

merged 1 commit into from Apr 10, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 9, 2021

PR description:

Minor fixes which I forgot to append to #33353.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33385/21993

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Validation/MuonCSCDigis

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a7d10/14140/summary.html
COMMIT: c8c8a7b
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33385/14140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 40
  • DQMHistoTests: Total successes: 2865437
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 15.0 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.750 KiB MuonCSCDigisV/CSCDigiTask
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f17cb26 into cms-sw:master Apr 10, 2021
@dildick dildick deleted the from-CMSSW_11_3_X_2021-04-06-1100-Fix-validation-title-binning branch April 12, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants