Change "eight" to "eighth" in the CSC CLCT and LCT data format (CCLUT-14)

[dildick]

PR description:

Grammatical change in the CSC CLCT and LCT data format, to avoid confusion between 8 neighboring strips and 1/8 of a strip. I used these commands in DataFormats/CSCDigi and L1Trigger/CSCTriggerPrimitives

git grep -lz eight | xargs -0 sed -i -e 's/eight/eighth/g'
git grep -lz EightStrip | xargs -0 sed -i -e 's/EightStrip/EighthStrip/g'

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33387/22000

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/CSCDigi/interface/CSCCLCTDigi.h modified in PR(s): New binning of Run-3 CLCT slope (CCLUT-13) #33380
  • File DataFormats/CSCDigi/interface/CSCCorrelatedLCTDigi.h modified in PR(s): New binning of Run-3 CLCT slope (CCLUT-13) #33380
  • File DataFormats/CSCDigi/src/CSCCLCTDigi.cc modified in PR(s): New binning of Run-3 CLCT slope (CCLUT-13) #33380
  • File DataFormats/CSCDigi/src/CSCCorrelatedLCTDigi.cc modified in PR(s): New binning of Run-3 CLCT slope (CCLUT-13) #33380
  • File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): New binning of Run-3 CLCT slope (CCLUT-13) #33380

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

+l1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b65d5d/14142/summary.html
COMMIT: f4ae5ab
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33387/14142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865477
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1