Run3-gex65 Update EB to adjust overlaps: work for DDD, need more work for DD4Hep

[bsunanda]

PR description:

Update EB to adjust overlaps: work for DDD, need more work for DD4Hep

PR validation:

Use runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33390/22006

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33390/22006/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33390/22006/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33390/22007

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/EcalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @rchatter, @argiro, @Martin-Grunewald, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-128882/14151/summary.html
COMMIT: 5960033
CMSSW: CMSSW_11_3_X_2021-04-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33390/14151/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3075 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 8429
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2857055
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 1 / 37 workflows

[bsunanda]

@silviodonato @qliphy @cvuosalo @srimanob Can this be included in the pre6?

[ianna]

+1

@bsunanda - I see you have included the 1 mm adjustment for the EcalBarrel mother volume. Thanks!

[bsunanda]

@ianna Yes - that is important for both DDD and DD4Hep. I am waiting for the fix in dd4hep to check the numbering for EcalBarrel and your new code

[srimanob]

Urgent

[srimanob]

Hi @ianna @bsunanda
This PR makes me question how do you plan for the near future development of DDD and DD4Hep for Run-3. As of now, we are validating them, so I expect that we should update both in the same PR, to avoid confusion on which one goes to which release/GT.

[bsunanda]

When we update a xml file, it automatically updates both DDD and DD4Hep scenario. If we fix an algorithm we see that the same algorithm for the other scenario is also corrected to the best of our knowledge. So each PR takes care of both DDD and DD4Hep

…

________________________________ From: Phat Srimanobhas ***@***.*** Sent: 12 April 2021 15:53 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex65 Update EB to adjust overlaps: work for DDD, need more work for DD4Hep (#33390) Hi @ianna<https://github.com/ianna> @bsunanda<https://github.com/bsunanda> This PR makes me question how do you plan for the near future development of DDD and DD4Hep for Run-3. As of now, we are validating them, so I expect that we should update both in the same PR, to avoid confusion on which one goes to which release/GT. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#33390 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOU4TQGNCRHLROMYHXDTIL3OZANCNFSM42VRPF2Q>.

[srimanob]

Thanks for the clarification @bsunanda . Then what is "need more work for DD4Hep" in the PR title?

[bsunanda]

Yes as mentioned in the SIM meeting, we still have to work on the algorithms for DD4Hep regarding Ecal Barrel and Preshower. Ianna's changes for EB removes overlaps for EB - but has issues for numbering scheme. Ianna is working with DD4Hep team to address this issue.

[srimanob]

+Upgrade

Thanks @bsunanda for the clarification.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1