Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4 10.7 physics configurations update #33400

Merged
merged 7 commits into from Apr 13, 2021

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Apr 11, 2021

PR description:

With Geant4 10.7 new features and updated components of Physics List are available. In this PR these updates are included everywhere except production Physics List in order to keep regression.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

no

@civanch
Copy link
Contributor Author

civanch commented Apr 11, 2021

@bsunanda , here 10.7 updates are added except FTFP_BERT_EMM, electromagnetic part affect histories, so left unchanged for the time being.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22025

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22026

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/PhysicsLists
SimG4Core/Watcher

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Apr 11, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53f6dd/14161/summary.html
COMMIT: 52ca29d
CMSSW: CMSSW_11_3_X_2021-04-11-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33400/14161/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ Running edmWriteConfigs for LaserAlignmentSimulationPlugins
--- Registered EDM Plugin: LaserAlignmentSimulationPlugins
Entering library rule at src/Alignment/LaserAlignmentSimulation/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc: In constructor 'LaserOpticalPhysics::LaserOpticalPhysics(const edm::ParameterSet&)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc:32:47: error: no matching function for call to 'CMSEmStandardPhysics::CMSEmStandardPhysics(int&)'
   32 |   RegisterPhysics(new CMSEmStandardPhysics(ver));
      |                                               ^
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc:16:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/SimG4Core/PhysicsLists/interface/CMSEmStandardPhysics.h:12:3: note: candidate: 'CMSEmStandardPhysics::CMSEmStandardPhysics(G4int, const edm::ParameterSet&)'
   12 |   CMSEmStandardPhysics(G4int ver, const edm::ParameterSet& p);


@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22057

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33400 was updated. @malbouis, @civanch, @yuanchao, @christopheralanwest, @mdhildreth, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

@civanch
Copy link
Contributor Author

civanch commented Apr 12, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53f6dd/14193/summary.html
COMMIT: a4b17bc
CMSSW: CMSSW_11_3_X_2021-04-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33400/14193/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865526
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Apr 13, 2021

+1

@civanch
Copy link
Contributor Author

civanch commented Apr 13, 2021

urgent

@civanch
Copy link
Contributor Author

civanch commented Apr 13, 2021

@christopheralanwest, please, resign this PR - I make modification to keep regression, it is clean now.

@francescobrivio
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ba40c3 into cms-sw:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants