New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geant4 10.7 physics configurations update #33400
Conversation
@bsunanda , here 10.7 updates are added except FTFP_BERT_EMM, electromagnetic part affect histories, so left unchanged for the time being. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22025
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22026
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: @@@@ Running edmWriteConfigs for LaserAlignmentSimulationPlugins --- Registered EDM Plugin: LaserAlignmentSimulationPlugins Entering library rule at src/Alignment/LaserAlignmentSimulation/plugins >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc: In constructor 'LaserOpticalPhysics::LaserOpticalPhysics(const edm::ParameterSet&)': /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc:32:47: error: no matching function for call to 'CMSEmStandardPhysics::CMSEmStandardPhysics(int&)' 32 | RegisterPhysics(new CMSEmStandardPhysics(ver)); | ^ In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/Alignment/LaserAlignmentSimulation/plugins/LaserOpticalPhysics.cc:16: /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-04-11-0000/src/SimG4Core/PhysicsLists/interface/CMSEmStandardPhysics.h:12:3: note: candidate: 'CMSEmStandardPhysics::CMSEmStandardPhysics(G4int, const edm::ParameterSet&)' 12 | CMSEmStandardPhysics(G4int ver, const edm::ParameterSet& p); |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33400/22057
|
Pull request #33400 was updated. @malbouis, @civanch, @yuanchao, @christopheralanwest, @mdhildreth, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53f6dd/14193/summary.html Comparison SummarySummary:
|
+1 |
urgent |
@christopheralanwest, please, resign this PR - I make modification to keep regression, it is clean now. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
With Geant4 10.7 new features and updated components of Physics List are available. In this PR these updates are included everywhere except production Physics List in order to keep regression.
PR validation:
private
if this PR is a backport please specify the original PR and why you need to backport that PR:
no