Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WToLNu and WprimeToLNu genFragments at 14 TeV #33407

Merged
merged 5 commits into from May 4, 2021

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Apr 12, 2021

PR description:

as requested in JIRA https://its.cern.ch/jira/browse/PDMVRELVALS-120
there is the need of having both the W and W' to leptons added --back-- to the relval matrix

in this PR, both the W and W' to leptons gen fragments for their production at 14 TeV have been added.
in addition, the WM_14TeV_TuneCUETP8M1_cfi.py has been fixed

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33407/22037

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Apr 12, 2021

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88b2a/14175/summary.html
COMMIT: 4481c9c
CMSSW: CMSSW_11_3_X_2021-04-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33407/14175/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1264 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 3674
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 2861791
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.703 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33407/22074

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33407 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@agrohsje
Copy link

Hi @mtosi . Request looks good to me (modulo naming inconsistencies in this folder, not your fault). Small question, what is the reason to add CUET instead of e.g. CP2. We could test stability of the tunes w. respect to P8 for tunes that we will really use in production.

@chayanit
Copy link

assign pdmv

@cmsbuild
Copy link
Contributor

New categories assigned: pdmv

@chayanit,@wajidalikhan,@jordan-martins you have been requested to review this Pull request/Issue and eventually sign? Thanks

@chayanit
Copy link

Hello @agrohsje , @mtosi we will need only WToLNu and WprimeToLNu for the RelVals. I'm not sure if we need both Tunes. I will let GEN conveners to approve the correctness. Thanks a lot.

@cmsbuild cmsbuild removed this from the CMSSW_11_3_X milestone Apr 15, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33407/22359

  • This PR adds an extra 28KB to repository

  • Found files with invalid states:

    • Configuration/Generator/python/WprimeToLNu_M2000_14TeV_TuneCUETP8M1_cfi.py:
    • Configuration/Generator/python/WprimeToLNu_M2000_14TeV_TuneCP5_cfi.py:
    • Configuration/Generator/python/WToLNu_14TeV_TuneCUETP8M1_cfi.py:
    • Configuration/Generator/python/WM_14TeV_TuneCP5_cfi.py:
    • Configuration/Generator/python/WToLNu_14TeV_TuneCP5_cfi.py:

@cmsbuild
Copy link
Contributor

Pull request #33407 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@agrohsje
Copy link

Thanks a lot @mtosi

@agrohsje
Copy link

+generators

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88b2a/14683/summary.html
COMMIT: b06f594
CMSSW: CMSSW_12_0_X_2021-04-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33407/14683/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877605
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877574
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mtosi
Copy link
Contributor Author

mtosi commented Apr 30, 2021

@chayanit could we proceed w/ this PR ? and the corresponding relval production in pre5 and pre6 as requested in JIRA [1]?
while writing this, I realised I have to do a backport !!!! let me do it

[1]
https://its.cern.ch/jira/projects/PDMVRELVALS/issues/PDMVRELVALS-120

@chayanit
Copy link

This PR will be merged to final 11_3_0. I don't think you can backport to pre5 and pre6. Do you really need them to be produced in those two pre-releases? Then we will need to manually add GEN fragment. @mtosi

@mtosi
Copy link
Contributor Author

mtosi commented May 3, 2021

ciao, yes, we would need in pre6 (and pre5 as reference)

@chayanit
Copy link

chayanit commented May 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 4, 2021

+1

@cmsbuild cmsbuild merged commit 303194a into cms-sw:master May 4, 2021
cmsbuild added a commit that referenced this pull request May 4, 2021
add WToLNu and WprimeToLNu genFragments at 14 TeV [backport #33407]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants