New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trackingMaterialGroups_ForPhaseII.xml from T25/T26 dict #33422
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33422/22083
|
A new Pull Request was created by @adewit for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@adewit out of curiosity, what messages was it giving? |
@cmsbuild, please test |
@mmusich it's exactly the same issue (so e.g.
) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1373a5/14222/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This removes an XML for material budget analysis from two recent tracker geometries (T25, T26; incorporated in D80 and D81). The file is not compatible with these geometries and leads to a few warnings in the standard workflows (not picked up when originally integrating these geometries). While the actual results of the workflows are not affected, it's best to remove these files to avoid triggering the warnings.
@emiglior fyi
PR validation:
Compared figures (IT, OT, tracking) in the DQM output wf 36634.0 with and without trackingMaterialGroups_ForPhaseII included to ensure the results are the same.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport