Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackingMaterialGroups_ForPhaseII.xml from T25/T26 dict #33422

Merged
merged 1 commit into from Apr 16, 2021

Conversation

adewit
Copy link
Contributor

@adewit adewit commented Apr 13, 2021

PR description:

This removes an XML for material budget analysis from two recent tracker geometries (T25, T26; incorporated in D80 and D81). The file is not compatible with these geometries and leads to a few warnings in the standard workflows (not picked up when originally integrating these geometries). While the actual results of the workflows are not affected, it's best to remove these files to avoid triggering the warnings.

@emiglior fyi

PR validation:

Compared figures (IT, OT, tracking) in the DQM output wf 36634.0 with and without trackingMaterialGroups_ForPhaseII included to ensure the results are the same.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33422/22083

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @adewit for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 13, 2021

@adewit out of curiosity, what messages was it giving?
This sounds related to this #31112 (comment)

@mmusich
Copy link
Contributor

mmusich commented Apr 13, 2021

@cmsbuild, please test

@adewit
Copy link
Contributor Author

adewit commented Apr 13, 2021

@adewit out of curiosity, what messages was it giving?
This sounds related to this #31112 (comment)

@mmusich it's exactly the same issue (so e.g.

%MSG
%MSG-e Specific:  AfterModGlobalBeginRun 12-Apr-2021 17:47:57 CEST Run: 1
Could not process q-name of a DDLogicalPart, reason:
No regex-match for namespace=  name=ITLayer1R2BModuleInnerPixelActive

)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1373a5/14222/summary.html
COMMIT: 04518bf
CMSSW: CMSSW_11_3_X_2021-04-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33422/14222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865526
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021
@qliphy
Copy link
Contributor

qliphy commented Apr 16, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants