Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Added new filter, thought for a B -> l HNL X analysis #33432

Merged

Conversation

mgratti
Copy link
Contributor

@mgratti mgratti commented Apr 14, 2021

PR description:

Backport of #33308

Needed for an MC production with B-parking conditions.

@mgratti mgratti changed the title added new filter, thought for a B -> l HNL X analysis [backport] Added new filter, thought for a B -> l HNL X analysis Apr 14, 2021
@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Apr 14, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mgratti (Maria Giulia Ratti) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Apr 15, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2f446/14248/summary.html
COMMIT: c2df457
CMSSW: CMSSW_10_2_X_2021-04-11-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33432/14248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1045 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2088
  • DQMHistoTests: Total nulls: 51
  • DQMHistoTests: Total successes: 3005217
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 56.705 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 10.938 KiB Info/EventInfo
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 140.53 ): 0.064 KiB SiStrip/MechanicalView
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

+generators

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2021

+1

@cmsbuild cmsbuild merged commit 72354a7 into cms-sw:CMSSW_10_2_X Apr 20, 2021
@mgratti
Copy link
Contributor Author

mgratti commented May 12, 2021

@silviodonato, @dpiparo, @qliphy
I have realized that, while this PR was merged almost a month ago, it was not actually integrated in the latest available 10_2_X release, CMSSW_10_2_26. Could you please comment? Thank you!

@qliphy
Copy link
Contributor

qliphy commented May 12, 2021

@mgalanti The last 10_2 release i.e. 10_2_26 was made in early March, so before this PR merged.
https://hypernews.cern.ch/HyperNews/CMS/get/relAnnounce/2185.html
We can make a 10_2_X to include this PR in next days.

@mgratti
Copy link
Contributor Author

mgratti commented May 12, 2021

Thank you!

@silviodonato
Copy link
Contributor

@mgratti https://github.com/cms-sw/cmssw/releases/CMSSW_10_2_26_patch1
will be available if few minutes/hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants