Use Lorentz Angle from data base for pixel template CPE's in case of error #33495
Conversation
…emplate reco failures. Also cleanup naming of some pixel CPE configuration parameters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33495/22227
|
|
A new Pull Request was created by @OzAmram (Oz Amram) for master. It involves the following packages: HLTrigger/Configuration @perrotta, @cmsbuild, @slava77, @Martin-Grunewald, @fwyzard, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
type bug-fix |
| @@ -129,11 +129,26 @@ def customiseFor2018Input(process): | |||
|
|
|||
| return process | |||
|
|
|||
| def customiseForPixelCPE(process): | |||
There was a problem hiding this comment.
@OzAmram I think it's customary to call these customisations with the PR number, e.g. customiseFor33495.
@Martin-Grunewald can comment if this is acceptable.
There was a problem hiding this comment.
@OzAmram I think it's customary to call these customisations with the PR number, e.g.
customiseFor33495.
@Martin-Grunewald can comment if this is acceptable.
@OzAmram please add the PR number as suggested by @mmusich : if you do so, once the PR will get merged, it will be easier for @Martin-Grunewald to identify the customization that can be removed
There was a problem hiding this comment.
Ok I just updated the name
|
@duartej can you please post in this thread the validation plots about the effect of this fix on the pixel template CPE reco for geometry T23? |
Here they are. The plots below shows how the problematic population (marked within the circles in the left small plots) disappear after the fix is applied (right plots).
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33495/22242
|
|
@cmsbuild, please test |
|
Ok I just pushed a new commit with the updates based on the comments |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33495/22295
|
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c9d6c/14589/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR updates the template reco CPE's (PixelCPETemplate and PixelCPEClusterRepair) to use the Lorentz Angle value from the database in the case of a template reconstruction error rather than using outdated hardcoded values. This has been a known issue for quite a while but has come up again during tests of the Phase 2 3D pixel integration (link).
In general these template reconstruction errors are quite rare, so the overall effect of these changes is expected to be quite small.
PR Testing
Testing has been done on phase 1 workflows with TTbar + Pu with 2024 conditions. The difference in hit residuals and tracking performance is very minor.
Slides here
Full tracking validation plots here
Link to Pixel Offline (virtual) meeting slides
Because of the update to the HLT configuration, the addOnTests have been run as well.