New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Phase II EB electron and photon IDs #33518
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33518/22274
|
A new Pull Request was created by @jainshilpi for master. It involves the following packages: RecoEgamma/ElectronIdentification @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73484/14571/summary.html Comparison SummarySummary:
|
@jainshilpi is it expected that nothing changed in the reco tests? Are these new working points used in some workflow already, or is it for the future? Thanks for clarifying! |
@@ -0,0 +1,57 @@ | |||
from RecoEgamma.PhotonIdentification.Identification.mvaPhotonID_tools import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for maintainability, would it be possible to import explicitly using
from RecoEgamma.PhotonIdentification.Identification.mvaPhotonID_tools import x,y,z
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be there in all such similar files in ElectronIdentification as well in PhotonIdentification. It would need change in all such files. Shall we aim that for a separate PR? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, true, it's probably better done in a separate cleaning PR
Hi Joosep, nothing is expected to change since currently only the cfg files needed to run VID on the fly are put in. To enable analysers to access the ID decisions, we have EgammaPostRecoTools which can be used on the fly. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This new PR (closed #33514) concerns the addition of configs needed for running VID for phase II EB photon (MVA based) and electron IDs (cut based). The added configs can then be used by analysers with EgammaPostRecoTools to embed in the PAT objects. Files modified/added:
(1) RecoEgamma/ElectronIdentification/python/Identification/cutBasedElectronID_Summer20_PhaseII_V0_cff.py
(2) RecoEgamma/PhotonIdentification/python/Identification/mvaPhotonID_Summer20_PhaseII_V0_cff.py
(3) RecoEgamma/PhotonIdentification/python/PhotonMVAValueMapProducer_cfi.py
The related presentations can be seen here:
Phase II photon ID: https://indico.cern.ch/event/879937/contributions/4108370/
Phase II electron ID: https://indico.cern.ch/event/1000891/contributions/4203637/
PR for MVA files for photon (phase II) ID is here:
cms-data/RecoEgamma-PhotonIdentification#8