Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of private frontier Key for workflow-specific caching #33558

Merged
merged 1 commit into from Apr 30, 2021

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 28, 2021

PR description:

We are enabling the use of workflow-specific private keys for the condition data access with frontier. The goal is ensuring that the fresh-keys identifying the cached data in the squids are not shared with other workflows/processes. In this way, unintended interferences and unwanted data are avoided.

The keys will be provided as an external parameter for the read-only ESSource-based workflows, and as the content of a specified file for the update-capable workflows.

PR validation:

Unit tests and integration tests

Backport of #33505

The backport is required to operate the online workflows: HLT, DQM/BeamSpot

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Apr 28, 2021
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_11_3_X.

It involves the following packages:

CondCore/DBOutputService
CondCore/ESSources

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Apr 28, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d463cd/14648/summary.html
COMMIT: f2c9ec9
CMSSW: CMSSW_11_3_X_2021-04-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33558/14648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@ggovi
Copy link
Contributor Author

ggovi commented Apr 28, 2021

+1

@tlampen
Copy link
Contributor

tlampen commented Apr 30, 2021

+alca

  • comparisons ok
  • backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 30, 2021

+1

@cmsbuild cmsbuild merged commit 7d32e5a into cms-sw:CMSSW_11_3_X Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants