Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4he] Disable DD4hep workflow 11634.911 in PR tests while it produces unstable results #33568

Merged
merged 1 commit into from Apr 29, 2021

Conversation

cvuosalo
Copy link
Contributor

The DD4hep workflow 11634.911 is once again showing instability in its results. For several weeks it was stable, but some recent change, possibly the new versions of DD4hep and ROOT, has re-activated its instability. Any change in the geometry causes a change in the simulation histories, which then changes the bit-wise results of simulation, even if there are no qualitative changes. Somehow, from run to run of the workflow, the geometry can be slightly changed, possibly due to an uninitialized variable taking on different values each time.

Note that the instability being observed is on the 10% level, that is, about 90% of the time the workflow produces consistent results.

The failed comparisons in PR tests for this workflow create unnecessary confusion, so it is best to remove the workflow for now until the instability can be resolved.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33568/22362

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dd385/14686/summary.html
COMMIT: 9610c2c
CMSSW: CMSSW_12_0_X_2021-04-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33568/14686/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662700
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2662669
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

merge
to include it in the morning IB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants