Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming cfgs and cffs #33599

Merged
merged 3 commits into from May 7, 2021
Merged

Renaming cfgs and cffs #33599

merged 3 commits into from May 7, 2021

Conversation

theofil
Copy link
Contributor

@theofil theofil commented May 1, 2021

PR description:

  • renaming cfgs and cffs to conform with naming conventions
  • moving 2 cffs from Herwig7Interface/python to Configuration/Generator to be included in validation workflows https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_extendedgen.py
  • this PR should be followed by another PR (or amended) adding the DYToll012Jets_5f_NLO_FXFX_Madgraph_Herwig_13TeV_cff.py and DYToll01234Jets_5f_LO_MLM_Madgraph_Herwig_13TeV_cff.py in PyReleaseValidation workflows with appropriate numbering
  • once the above is ready, back port to 10_6_X will follow with a new PR

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone May 1, 2021
@theofil theofil mentioned this pull request May 1, 2021
Closed
@theofil theofil changed the title Renaming cf gs Renaming cfgs and cffs May 1, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33599/22414

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2021

A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @mkirsano, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented May 2, 2021

please test

@silviodonato
Copy link
Contributor

please abort

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcf239/14787/summary.html
COMMIT: 90429cb
CMSSW: CMSSW_12_0_X_2021-05-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33599/14787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
312.0 step 1
25202.0 step 2
10224.0 step 2
250202.181 step 2
34834.999 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 97 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 17
  • DQMHistoTests: Total histograms compared: 1625174
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1625163
  • DQMHistoTests: Total skipped: 10
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 16 files compared)
  • Checked 96 log files, 4 edm output root files, 17 DQM output files
  • TriggerResults: no differences found

@theofil
Copy link
Contributor Author

theofil commented May 3, 2021

@agrohsje updated the PR with the 2 new names we discussed for the amcatnlo/madgraph

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33599/22430

  • This PR adds an extra 32KB to repository

  • Found files with invalid states:

    • Configuration/Generator/python/DYToll012Jets_5f_NLO_FXFX_Madgraph_Herwig_13TeV_cff.py:
    • Configuration/Generator/python/DYToll01234Jets_5f_LO_MLM_Madgraph_Herwig_13TeV_cff.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

Pull request #33599 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

agrohsje
agrohsje reviewed May 4, 2021
View reviewed changes
...Interface/Herwig7Interface/test/DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7_cfg.py
'set /Herwig/Shower/FxFxHandler:MPIHandler /Herwig/UnderlyingEvent/MPIHandler',
'set /Herwig/Shower/FxFxHandler:RemDecayer /Herwig/Partons/RemnantDecayer',
'set /Herwig/Shower/FxFxHandler:ShowerAlpha AlphaQCD',
'set FxFxHandler:HeavyQVeto Yes',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dominic-Stafford : Did you check how to apply the setting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andreas said that this setting should be set to "Yes" if we want to match the b jets to b quarks, and recommended we do this- apparently this is independent of whether we use the 4fs or the 5fs

@agrohsje
Copy link

agrohsje commented May 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcf239/14895/summary.html
COMMIT: 0ff88d1
CMSSW: CMSSW_12_0_X_2021-05-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33599/14895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2662623
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented May 6, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 7, 2021

+1

@cmsbuild cmsbuild merged commit 89aac0a into cms-sw:master May 7, 2021
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
@colizz
Renaming cfgs and cffs (10_6_X)
fa138ea 
Backport cms-sw#33599 to 10_6_X
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
@colizz
Renaming cfgs and cffs (10_6_X)
54a5120 
Backport cms-sw#33599 to 10_6_X
@colizz colizz mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrohsje agrohsje agrohsje left review comments

@Dominic-Stafford Dominic-Stafford Dominic-Stafford left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_0_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@theofil @cmsbuild @SiewYan @silviodonato @agrohsje @qliphy @Dominic-Stafford