Fix typo in the fillDescriptions method of RecoParticleFlow/PFClusterProducer/interface/HGCRecHitNavigator.h

[perrotta]

PR description:

Fixed a typo in the name of one PSet, when filling its parameter content

PR validation:

It builds

As far as I can see, the hgcheb PSet is explicitely redefined when used in the actual configs:

• RecoEgamma/EgammaHLTProducers/python/HLTEgPhaseIITestSequence_cff.py
• RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitHGC_cfi.py

Therefore, even though the PSet were wrongly defined in the fillDescription method of the HGCRecHitNavigator, I don't expect any effect on the outputs: let have a look at the automatic tests results, anyhow.

[perrotta]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33618/22463

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @clelange, @lecriste, @hatakeyamak, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a636b/14830/summary.html
COMMIT: 6509a1f
CMSSW: CMSSW_12_0_X_2021-05-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33618/14830/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662611
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• The fix is rather obvious; it has however no effect on reco outputs because the bugged hgcheb PSet is explicitely redefined whenever used in the actual configs, and the wrong configuration from the fillDescriptions methods gets overwritte

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1