[HGCAL trigger] Fixing phi smoothing in cluster seeding

[jbsauvan]

PR description:

Fixes smoothing normalization in the phi direction for the cluster seeding.
A more detailed description and plots can be found in this presentation:
https://indico.cern.ch/event/953230/contributions/4010533/

To summarize:

• This seeding fix impacts the population of PU clusters, in particular their eta distribution, but the seeding threshold has been tuned to in order to have roughly the same numbers of clusters reconstructed from PU as before.
• There is a slight improvement of e/g energy resolution (before corrections are applied)

PR validation:

Standard code checks and code-format, as well as testing workflows 23234.0 (v11 geometry) and 31434.0 (v12 geometry)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33621/22476

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e625/14868/summary.html
COMMIT: 55cf094
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33621/14868/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662605
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[srimanob]

@jbsauvan
Would you mind to provide more detail, i.e. what change do you expect and how to look for it (DQM, plots)? Since I don't see any changes in workflow 23234.0 from PR test. This information should be in the PR description. Thanks.

[jbsauvan]

Thanks @srimanob
I'm not sure there are DQM plots produced for the HGCAL trigger primitives.

This change has been discussed in HGCAL meetings, you can for instance find a more detailed description and plots in this presentation:
https://indico.cern.ch/event/953230/contributions/4010533/

To summarize:

• This seeding fix impacts the population of PU clusters, in particular their eta distribution, but the seeding threshold has been tuned to in order to have roughly the same numbers of clusters reconstructed from PU as before.
• We see a slight improvement of e/g energy resolution (before corrections are applied)

[I'll copy these information in the PR description as well]

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1