Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] MTD geometry: update mtdParameters for D49 and D60 (Bug fix) #33657

Merged
merged 1 commit into from May 10, 2021

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented May 7, 2021

PR description:

Backport of #33647 by @parbol , fixes the unintentional use of old parameters as frame gaps for ETL pixels in scenarios D49 and D60 (where no frame was used in the past). Although strictly speaking it is a bug fix, it is not important unless someone tries to seriously use MTD in D49 or D60 in 11_3_X (which should be considered as obsolete). The net effect of the fix is anyway minor, it is mostly meant to avoid confusion in the future.

PR validation:

Verified in 12_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_11_3_X.

It involves the following packages:

Geometry/MTDCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented May 7, 2021

backport #33647

@fabiocos
Copy link
Contributor Author

fabiocos commented May 7, 2021

type bug

@fabiocos
Copy link
Contributor Author

fabiocos commented May 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-039a27/14936/summary.html
COMMIT: 03f2b87
CMSSW: CMSSW_11_3_X_2021-05-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33657/14936/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6124 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 69370
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2807649
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

cvuosalo commented May 7, 2021

+1

@srimanob
Copy link
Contributor

+1

Backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 10, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants