New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] MTD geometry: update mtdParameters for D49 and D60 (Bug fix) #33657
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_11_3_X. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport #33647 |
type bug |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-039a27/14936/summary.html Comparison SummarySummary:
|
+1 |
+1 Backport |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #33647 by @parbol , fixes the unintentional use of old parameters as frame gaps for ETL pixels in scenarios D49 and D60 (where no frame was used in the past). Although strictly speaking it is a bug fix, it is not important unless someone tries to seriously use MTD in D49 or D60 in 11_3_X (which should be considered as obsolete). The net effect of the fix is anyway minor, it is mostly meant to avoid confusion in the future.
PR validation:
Verified in 12_0_X.